linux-kernel - Re: [PATCH v1] drm/amdgpu: lock bo before calling amdgpu_vm_bo_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c619ad7-5502-42bc-8de8-8bf2af2e9566@amd.com>
Date: Tue, 28 Oct 2025 14:26:26 +0100
From: Christian König <christian.koenig@....com>
To: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>,
 Alex Deucher <alexander.deucher@....com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] drm/amdgpu: lock bo before calling
 amdgpu_vm_bo_update_shared

On 10/28/25 14:09, Pierre-Eric Pelloux-Prayer wrote:
> BO's reservation object must be locked before using
> amdgpu_vm_bo_update_shared otherwise dma_resv_assert_held will
> complain in amdgpu_vm_update_shared.
> 
> Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> index ff98c87b2e0b..830412f04b6c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> @@ -81,13 +81,20 @@ static int amdgpu_dma_buf_attach(struct dma_buf *dmabuf,
>  	struct drm_gem_object *obj = dmabuf->priv;
>  	struct amdgpu_bo *bo = gem_to_amdgpu_bo(obj);
>  	struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev);
> +	int r;
>  
>  	if (!amdgpu_dmabuf_is_xgmi_accessible(attach_adev, bo) &&
>  	    pci_p2pdma_distance(adev->pdev, attach->dev, false) < 0)
>  		attach->peer2peer = false;
>  
> +	r = dma_resv_lock(bo->tbo.base.resv, NULL);
> +	if (r)
> +		return r;
> +
>  	amdgpu_vm_bo_update_shared(bo);
>  
> +	dma_resv_unlock(bo->tbo.base.resv);
> +
>  	return 0;
>  }
>