linux-kernel - Re: [PATCH RFC 0/3] Add splash DRM client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c75bbb5-907c-439e-b442-ebbac5056bcc@amd.com>
Date: Tue, 28 Oct 2025 08:39:09 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Francesco Valla <francesco@...la.it>, Maxime Ripard <mripard@...nel.org>
Cc: Thomas Zimmermann <tzimmermann@...e.de>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Jonathan Corbet <corbet@....net>, Jocelyn Falempe <jfalempe@...hat.com>,
 Javier Martinez Canillas <javierm@...hat.com>,
 Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
 linux-embedded@...r.kernel.org
Subject: Re: [PATCH RFC 0/3] Add splash DRM client

On 10/28/25 3:09 AM, Francesco Valla wrote:
> Hi,
> 
> On Monday, 27 October 2025 at 18:19:12 Maxime Ripard <mripard@...nel.org> wrote:
>> On Mon, Oct 27, 2025 at 11:31:06AM -0500, Mario Limonciello wrote:
>>> On 10/27/25 11:28 AM, Maxime Ripard wrote:
>>>> On Mon, Oct 27, 2025 at 11:01:55AM -0500, Mario Limonciello wrote:
>>>>> On 10/27/25 7:35 AM, Thomas Zimmermann wrote:
>>>>>>>>      - a very simple progress bar, which can be driven through sysfs;
>>>>>>
>>>>>> Once you have options to control these settings from user space, you
>>>>>> should do it in user space entirely. As Maxime suggested, please improve
>>>>>> plymouth for anything with animation.
>>>>>>
>>>>>>>>      - a static image (optional).
>>>>>>
>>>>>> Board vendors often provide an image, see /sys/firmware/acpi/bgrt/. This
>>>>>> is a candidate for display, or the penguin or a custom image. Please
>>>>>> make it configurable by Kconfig. Again, if you need policy and
>>>>>> heuristics for deciding what to display, you better do this in user
>>>>>> space.
>>>>>
>>>>> I'd actually argue that the static image from BGRT should be the preferred
>>>>> priority.  This can make for a nice hand off to Plymouth.
>>>>>
>>>>> The (UEFI) BIOS already will show this image as soon as the GOP driver is
>>>>> loaded.  Bootloaders like GRUB by default will avoid showing anything or
>>>>> will overwrite with the exact same image in the same location.  This can let
>>>>> the kernel do the same, and then the moment Plymouth takes over it could do
>>>>> the same.
>>>>
>>>> And BGRT isn't typically found on embedded systems at all, so I'm not
>>>> sure it's a sensible default, let alone a priority. At most a possible
>>>
>>> There are certainly embedded machines using UEFI and that have a BGRT.
>>
>> Yes, indeed, hence the "typically".
>>
>>> How about "Sensible default the top of the priority list if it exists"
>>
>> How about we don't tell contributors what their priorities must be?
>>
>> Maxime
>>
> 
> I'm not familiar at all with BGRT, I'll study a bit about it.
> 
> A build-time configuration could then let the user select:
> 
> - a plain solid color
> - a custom static image
> - the penguin logo (?)
> - (on UEFI systems) BGRT source

Thanks!

What I had in mind (which feel free to disagree - it's an RC afterall):

User can pick one of these:

CONFIG_SPLASH_IMAGE
CONFIG_SPLASH_COLOR

If user picks CONFIG_SPLASH_IMAGE then the default behavior would be 
UEFI BGRT with a fallback to a Linux penguin.

Additionally there could be a

CONFIG_SPLASH_CUSTOM_IMAGE

This would populate the path to a custom image at build time.

If user picks this then it would override both UEFI BGRT and Linux penguin.

> 
> 
> 
> Thank you
> 
> Regards,
> Francesco