linux-kernel - Re: [PATCH 06/19] serial: sh-sci: Drop extra line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251028103513.a107e9765c73926ceca8454a@hugovil.com>
Date: Tue, 28 Oct 2025 10:35:13 -0400
From: Hugo Villeneuve <hugo@...ovil.com>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
 <jirislaby@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Lad
 Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Wolfram Sang
 <wsa+renesas@...g-engineering.com>, Claudiu Beznea
 <claudiu.beznea.uj@...renesas.com>, Nam Cao <namcao@...utronix.de>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, Biju Das
 <biju.das.au@...il.com>, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 06/19] serial: sh-sci: Drop extra line

Hi Biju,

On Mon, 27 Oct 2025 15:45:53 +0000
Biju Das <biju.das.jz@...renesas.com> wrote:

> Shorten the number lines in sci_init_clocks() by fitting the error
> message within an 80-character length limit.
> 
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---
>  drivers/tty/serial/sh-sci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index b33894d0273b..699c39b81c4b 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -3009,8 +3009,7 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
>  
>  		if (!clk && sci_port->type == SCI_PORT_RSCI &&
>  		    (i == SCI_FCK || i == SCI_BRG_INT)) {
> -			return dev_err_probe(dev, -ENODEV,
> -					     "failed to get %s\n",
> +			return dev_err_probe(dev, -ENODEV, "failed to get %s\n",
>  					     name);

You can even put it all on one line with the now 100 columns limit.

>  		}
>  
> -- 
> 2.43.0
> 
> 

-- 
Hugo Villeneuve