linux-kernel - Re: [PATCH v9 05/22] x86/cea: Use array indexing to simplify exception stack access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3F67131F-BD5D-4A4D-AAFD-81993A448D42@zytor.com>
Date: Mon, 27 Oct 2025 19:31:25 -0700
From: Xin Li <xin@...or.com>
To: Dave Hansen <dave.hansen@...el.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        linux-doc@...r.kernel.org, pbonzini@...hat.com, seanjc@...gle.com,
        corbet@....net, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        luto@...nel.org, peterz@...radead.org, andrew.cooper3@...rix.com,
        chao.gao@...el.com, hch@...radead.org, sohil.mehta@...el.com
Subject: Re: [PATCH v9 05/22] x86/cea: Use array indexing to simplify
 exception stack access



> On Oct 27, 2025, at 8:49 AM, Dave Hansen <dave.hansen@...el.com> wrote:
> 
> On 10/26/25 13:18, Xin Li (Intel) wrote:
>> Refactor struct cea_exception_stacks to leverage array indexing for
>> exception stack access, improving code clarity and eliminating the
>> need for the ESTACKS_MEMBERS() macro.
>> 
>> Convert __this_cpu_ist_{bottom,top}_va() from macros to functions,
>> allowing removal of the now-obsolete CEA_ESTACK_BOT and CEA_ESTACK_TOP
>> macros.
>> 
>> Also drop CEA_ESTACK_SIZE, which just duplicated EXCEPTION_STKSZ.
>> 
>> Signed-off-by: Xin Li (Intel) <xin@...or.com>
>> ---
>> 
>> Change in v9:
>> * Refactor first and then export in a separate patch (Dave Hansen).
> 
> Thanks for the changes. This also removes the extra union{} that was in
> the last version for padding.

I would say you foresaw it because you suggested to use array indexing:

https://lore.kernel.org/lkml/720bc7ac-7e81-4ad9-8cc5-29ac540be283@intel.com/

Thanks a lot for making it much cleaner.
Xin