linux-kernel - Re: [RFT PATCH] xhci: sideband: Fix race condition in sideband unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db07f48d-27cf-4681-b10e-38d252e24512@linux.intel.com>
Date: Tue, 28 Oct 2025 16:59:18 +0200
From: Mathias Nyman <mathias.nyman@...ux.intel.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: uttkarsh.aggarwal@....qualcomm.com, linux-kernel@...r.kernel.org,
 linux-usb@...r.kernel.org, mathias.nyman@...el.com,
 wesley.cheng@....qualcomm.com
Subject: Re: [RFT PATCH] xhci: sideband: Fix race condition in sideband
 unregister

On 10/28/25 15:56, Greg KH wrote:

>> @@ -474,16 +494,23 @@ xhci_sideband_unregister(struct xhci_sideband *sb)
>>   	xhci = sb->xhci;
>>   
>>   	mutex_lock(&sb->mutex);
>> +
>> +	vdev = sb->vdev;
>> +	if (!vdev)
>> +		return;
> 
> Lock is still held :(
> 

Oops, missed one

> I think you need to use guard() to make this more sane.

Clearly yes, I'll send a v2

> 
> thanks,
> 
> greg k-h
> 

Thanks
Mathias