linux-kernel - Re: [PATCH] Documentation: Provide guidelines for kernel development tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72k7LQwXFnZgh8fCLNnx=v17Yb7yVcPQT_cdPi5k=17jbA@mail.gmail.com>
Date: Tue, 28 Oct 2025 16:29:14 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>, 
	Dan Williams <dan.j.williams@...el.com>, "Theodore Ts'o" <tytso@....edu>, 
	Sasha Levin <sashal@...nel.org>, Jonathan Corbet <corbet@....net>, Kees Cook <kees@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] Documentation: Provide guidelines for kernel development tools

Hi Dave,

Some more nits and suggestions below...

On Mon, Oct 27, 2025 at 9:13 PM Dave Hansen <dave.hansen@...ux.intel.com> wrote:
>
> Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>

No big deal either way, but for the commit you could use ojeda@...nel.org

> + - Spelling and grammar fix ups, like rephrasing to imperative voice

Some bullet points have periods at the end, others don't.

> + - Reformatting, like running scripts/Lindent.

You could perhaps add

    Lindent, ``clang-format`` or ``rustfmt``

or similar (the Rust one is particularly relevant because we enforce
that one treewide unlike the C one).

> + - “checkpatch.pl --fix” output, or any tool suggested fix.

We should use a code span for this one.

Also, should it be "tool-suggested", i.e. with a hyphen? (not a native speaker)

> + - coccinelle scripts

Coccinelle

> + - ChatGPT generated a new function in your patch to sort list entries.
> + - A .c file in the patch was originally generated by Gemini but cleaned
> +   up by hand.

Like Jon, it also crossed my mind using just LLM here or perhaps
mentioning "open" models. On the other hand, it is clear commercial
models are getting used already, e.g. Gemini is in the commit log
already and Claude is in the mailing list.

I hope that helps -- thanks for sending this!

Cheers,
Miguel