linux-kernel - Re: [PATCH v3 11/70] ns: add active reference count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251028-unvollendet-erzogen-a3ec83ca68bf@brauner>
Date: Tue, 28 Oct 2025 16:33:46 +0100
From: Christian Brauner <brauner@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-fsdevel@...r.kernel.org, Josef Bacik <josef@...icpanda.com>, 
	Jeff Layton <jlayton@...nel.org>, Jann Horn <jannh@...gle.com>, Mike Yuan <me@...dnzj.com>, 
	Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>, Lennart Poettering <mzxreary@...inter.de>, 
	Daan De Meyer <daan.j.demeyer@...il.com>, Aleksa Sarai <cyphar@...har.com>, 
	Amir Goldstein <amir73il@...il.com>, Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org, 
	cgroups@...r.kernel.org, bpf@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3 11/70] ns: add active reference count

On Mon, Oct 27, 2025 at 05:36:27PM +0100, Thomas Gleixner wrote:
> On Fri, Oct 24 2025 at 12:52, Christian Brauner wrote:
> > diff --git a/kernel/time/namespace.c b/kernel/time/namespace.c
> > index ee05cad288da..2e7c110bd13f 100644
> > --- a/kernel/time/namespace.c
> > +++ b/kernel/time/namespace.c
> > @@ -106,6 +106,7 @@ static struct time_namespace *clone_time_ns(struct user_namespace *user_ns,
> >  	ns->offsets = old_ns->offsets;
> >  	ns->frozen_offsets = false;
> >  	ns_tree_add(ns);
> > +	ns_ref_active_get_owner(ns);
> 
> It seems all places where ns_ref_active_get_owner() is added it is
> preceeded by a variant of ns_tree_add(). So why don't you stilck that
> refcount thing into ns_tree_add()? I'm probably missing something here.

Yes, as usual a very astute observation. I've taken your advice and
folded the parent count into __ns_tree_add_raw(). Thanks!