linux-kernel - Re: [PATCH v2 2/3] dt-bindings: spi: spi-cadence: update DT binding docs to support cix sky1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9f43492-859a-4369-b660-7fa138c86e86@cixtech.com>
Date: Tue, 28 Oct 2025 10:54:46 +0800
From: Jun Guo <jun.guo@...tech.com>
To: Conor Dooley <conor@...nel.org>
Cc: peter.chen@...tech.com, fugang.duan@...tech.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, broonie@...nel.org,
 linux-spi@...r.kernel.org, michal.simek@....com,
 cix-kernel-upstream@...tech.com, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: spi: spi-cadence: update DT binding
 docs to support cix sky1 SoC

Hi Conor,

Thank you for your prompt feedback.

On 10/28/2025 12:51 AM, Conor Dooley wrote:
> On Mon, Oct 27, 2025 at 04:42:38PM +0800, Jun Guo wrote:
>> - Add new compatible strings to the DT binding documents to support
>>   cix sky1 SoC;
>> - Adjust the configuration of the compatible property to support both
>>   single-item and two-items cases.
>>
>> Signed-off-by: Jun Guo<jun.guo@...tech.com>
>> ---
>>   .../devicetree/bindings/spi/spi-cadence.yaml          | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
>> index 8de96abe9da1..e75b142a1368 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
>> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
>> @@ -14,9 +14,14 @@ allOf:
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - cdns,spi-r1p6
>> -      - xlnx,zynq-spi-r1p6
>> +    oneOf:
>> +      - enum:
>> +          - cdns,spi-r1p6
>> +          - xlnx,zynq-spi-r1p6
>> +      - items:
>> +          - enum:
>> +              - cix,sky1-spi-r1p6
>> +          - const: cdns,spi-r1p6
> This doesn't apply, probably needs a rebase on spi/for-next?
> Approach is correct though, but it'll be a more minimal patch when
> rebased.
> pw-bot: changes-requested
> 
Thank you for the heads-up. I've just seen your patch, and I will base 
my PATCH v3 on top of it.>>
>>     reg:
>>       maxItems: 1
>> -- 
>> 2.34.1