linux-kernel - Re: [PATCH 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Kaanapali SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07c5c404-e2a7-418e-af5f-dc7c4df9f2f6@oss.qualcomm.com>
Date: Tue, 28 Oct 2025 11:02:07 +0800
From: "Aiqun(Maria) Yu" <aiqun.yu@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>,
        Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Odelu Kukatla <odelu.kukatla@....qualcomm.com>,
        Mike Tipton <mike.tipton@....qualcomm.com>
Cc: linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: document the RPMh
 Network-On-Chip interconnect in Kaanapali SoC

On 10/23/2025 2:23 PM, Krzysztof Kozlowski wrote:
> On 23/10/2025 06:39, Raviteja Laggyshetty wrote:
>> Document the RPMh Network-On-Chip Interconnect of the Kaanapali platform.
>>
>> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
> 
> 
> This cannot be tested, so there is little point in doing real review. We
> already provided guidance - and it is documented in your internal
> guideline document - what to do in such case. Please follow internal
> docs to decouple.


To be more specific:
Please drop header "<dt-bindings/clock/qcom,kaanapali-gcc.h>" and use
ephemeral clocks in the devices example like
<&gcc_aggre_ufs_phy_axi_clk> <&gcc_aggre_usb3_prim_axi_clk>
<&rpmhcc_ipa_clk>.


> 
> Best regards,
> Krzysztof

-- 
Thx and BRs,
Aiqun(Maria) Yu