linux-kernel - Re: [PATCH v5 20/23] ALSA: usb-audio: Convert to common field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ms5bf1hn.wl-tiwai@suse.de>
Date: Tue, 28 Oct 2025 17:13:40 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Michael Turquette <mturquette@...libre.com>,	Stephen Boyd
 <sboyd@...nel.org>,	Nicolas Ferre <nicolas.ferre@...rochip.com>,	Alexandre
 Belloni <alexandre.belloni@...tlin.com>,	Claudiu Beznea
 <claudiu.beznea@...on.dev>,	Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,	David Miller
 <davem@...emloft.net>,	Linus Walleij <linus.walleij@...aro.org>,	Bartosz
 Golaszewski <brgl@...ev.pl>,	Joel Stanley <joel@....id.au>,	Andrew Jeffery
 <andrew@...econstruct.com.au>,	Crt Mori <cmo@...exis.com>,	Jonathan Cameron
 <jic23@...nel.org>,	Lars-Peter Clausen <lars@...afoo.de>,	Jacky Huang
 <ychuang3@...oton.com>,	Shan-Chun Hung <schung@...oton.com>,	Yury Norov
 <yury.norov@...il.com>,	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Jaroslav Kysela <perex@...ex.cz>,	Takashi Iwai <tiwai@...e.com>,	Johannes
 Berg <johannes@...solutions.net>,	Jakub Kicinski <kuba@...nel.org>,	Alex
 Elder <elder@...e.org>,	David Laight <david.laight.linux@...il.com>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,	Jason Baron
 <jbaron@...mai.com>,	Borislav Petkov <bp@...en8.de>,	Tony Luck
 <tony.luck@...el.com>,	Michael Hennerich <Michael.Hennerich@...log.com>,
	Kim Seer Paller <kimseer.paller@...log.com>,	David Lechner
 <dlechner@...libre.com>,	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,	Richard Genoud
 <richard.genoud@...tlin.com>,	Cosmin Tanislav <demonsingur@...il.com>,	Biju
 Das <biju.das.jz@...renesas.com>,	Jianping Shen
 <Jianping.Shen@...bosch.com>,	linux-clk@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,	linux-renesas-soc@...r.kernel.org,
	linux-crypto@...r.kernel.org,	linux-edac@...r.kernel.org,
	qat-linux@...el.com,	linux-gpio@...r.kernel.org,
	linux-aspeed@...ts.ozlabs.org,	linux-iio@...r.kernel.org,
	linux-sound@...r.kernel.org,	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 20/23] ALSA: usb-audio: Convert to common field_{get,prep}() helpers

On Mon, 27 Oct 2025 19:41:54 +0100,
Geert Uytterhoeven wrote:
> 
> Drop the driver-specific field_get() and field_prep() macros, in favor
> of the globally available variants from <linux/bitfield.h>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> v5:
>   - Extracted from "bitfield: Add non-constant field_{prep,get}()
>     helpers".
> ---
>  sound/usb/mixer_quirks.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 713a8498b975e1ac..6eee89cbc0867f2b 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -3311,12 +3311,6 @@ static int snd_bbfpro_controls_create(struct usb_mixer_interface *mixer)
>  #define RME_DIGIFACE_REGISTER(reg, mask) (((reg) << 16) | (mask))
>  #define RME_DIGIFACE_INVERT BIT(31)
>  
> -/* Nonconst helpers */
> -#undef field_get
> -#define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
> -#undef field_prep
> -#define field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
> -
>  static int snd_rme_digiface_write_reg(struct snd_kcontrol *kcontrol, int item, u16 mask, u16 val)
>  {
>  	struct usb_mixer_elem_list *list = snd_kcontrol_chip(kcontrol);

Acked-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi