linux-kernel - Re: [PATCH 1/6 v6] ACPI: extlog: Trace CPER Non-standard Section Body

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf4e81e4-70c2-434d-960d-d3b2277ac8ca@linux.intel.com>
Date: Tue, 28 Oct 2025 09:19:43 -0700
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
 linux-cxl@...r.kernel.org
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
 Hanjun Guo <guohanjun@...wei.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Shuai Xue <xueshuai@...ux.alibaba.com>,
 Davidlohr Bueso <dave@...olabs.net>,
 Jonathan Cameron <jonathan.cameron@...wei.com>,
 Dave Jiang <dave.jiang@...el.com>,
 Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Mahesh J Salgaonkar <mahesh@...ux.ibm.com>,
 Oliver O'Halloran <oohall@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Sunil V L <sunilvl@...tanamicro.com>, Xiaofei Tan <tanxiaofei@...wei.com>,
 Mario Limonciello <mario.limonciello@....com>,
 Huacai Chen <chenhuacai@...nel.org>,
 Heinrich Schuchardt <heinrich.schuchardt@...onical.com>,
 Arnd Bergmann <arnd@...db.de>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...nel.org>, Guo Weikang <guoweikang.kernel@...il.com>,
 Xin Li <xin@...or.com>, Will Deacon <will@...nel.org>,
 Huang Yiwei <quic_hyiwei@...cinc.com>, Gavin Shan <gshan@...hat.com>,
 Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Li Ming <ming.li@...omail.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>,
 Karolina Stolarek <karolina.stolarek@...cle.com>,
 Jon Pan-Doh <pandoh@...gle.com>, Lukas Wunner <lukas@...ner.de>,
 Shiju Jose <shiju.jose@...wei.com>, linux-kernel@...r.kernel.org,
 linux-acpi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-pci@...r.kernel.org, Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Subject: Re: [PATCH 1/6 v6] ACPI: extlog: Trace CPER Non-standard Section Body

On 10/23/2025 5:25 AM, Fabio M. De Francesco wrote:
> ghes_do_proc() has a catch-all for unknown or unhandled CPER formats
> (UEFI v2.10 Appendix N 2.3), extlog_print() does not. This gap was

Latest is v2.11, right? Why not use it for reference?

> noticed by a RAS test that injected CXL protocol errors which were
> notified to extlog_print() via the IOMCA (I/O Machine Check
> Architecture) mechanism. Bring parity to the extlog_print() path by
> including a similar log_non_standard_event().
> 
> Cc: Dan Williams <dan.j.williams@...el.com>
> Reviewed-by: Dan Williams <dan.j.williams@...el.com>
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> Signed-off-by: Fabio M. De Francesco <fabio.m.de.francesco@...ux.intel.com>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

>  drivers/acpi/acpi_extlog.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c
> index f6b9562779de..47d11cb5c912 100644
> --- a/drivers/acpi/acpi_extlog.c
> +++ b/drivers/acpi/acpi_extlog.c
> @@ -183,6 +183,12 @@ static int extlog_print(struct notifier_block *nb, unsigned long val,
>  			if (gdata->error_data_length >= sizeof(*mem))
>  				trace_extlog_mem_event(mem, err_seq, fru_id, fru_text,
>  						       (u8)gdata->error_severity);
> +		} else {
> +			void *err = acpi_hest_get_payload(gdata);
> +
> +			log_non_standard_event(sec_type, fru_id, fru_text,
> +					       gdata->error_severity, err,
> +					       gdata->error_data_length);
>  		}
>  	}
>  

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer