linux-kernel - Re: [PATCH v4 07/16] mtd: rawnand: sunxi: rework pattern found registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7jz576u.fsf@bootlin.com>
Date: Tue, 28 Oct 2025 17:20:41 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Jernej Škrabec <jernej.skrabec@...il.com>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Rob Herring <robh@...nel.org>,  Krzysztof Kozlowski
 <krzk+dt@...nel.org>,  Conor Dooley <conor+dt@...nel.org>,  Chen-Yu Tsai
 <wens@...e.org>,  Samuel Holland <samuel@...lland.org>,  Richard Genoud
 <richard.genoud@...tlin.com>,  Uwe Kleine-König
 <u.kleine-koenig@...libre.com>,  Wentao Liang <vulab@...as.ac.cn>,  Johan
 Hovold <johan@...nel.org>,  Maxime Ripard <mripard@...nel.org>,  Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>,  linux-mtd@...ts.infradead.org,
  devicetree@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
  linux-sunxi@...ts.linux.dev,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 07/16] mtd: rawnand: sunxi: rework pattern found
 registers

On 28/10/2025 at 16:41:48 +01, Jernej Škrabec <jernej.skrabec@...il.com> wrote:

> Dne torek, 28. oktober 2025 ob 08:35:00 Srednjeevropski standardni čas je Richard Genoud napisal(a):
>> On H6/H616, the register ECC_PAT_FOUND is at its own address, and not
>> part of ECC status register.
>> So, introduce the pattern found register offset in sunxi_nfc_caps, along
>> with its mask.
>> 
>> Also, introduce a non compile-time field_get() because FIELD_GET() and
>> u32_get_bits() don't work with non compile-time constant.
>> https://lore.kernel.org/all/cover.1761588465.git.geert+renesas@glider.be
>
> Urls should use Link: tag and be placed at the bottom.

I was about to apply, so I'll fix this while applying.

>
> Code itself looks fine.

Thanks for the review!

Miquèl