linux-kernel - Re: [PATCH] net: tcp_lp: fix kernel-doc warnings and update outdated reference links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQDwGpQttEEsj9ik@horms.kernel.org>
Date: Tue, 28 Oct 2025 16:32:26 +0000
From: Simon Horman <horms@...nel.org>
To: Rakuram Eswaran <rakuram.e96@...il.com>
Cc: Eric Dumazet <edumazet@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, hswong3i@...il.com,
	hlhung3i@...il.com, khalid@...nel.org, skhan@...uxfoundation.org,
	david.hunter.linux@...il.com,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tcp_lp: fix kernel-doc warnings and update outdated
 reference links

On Sat, Oct 25, 2025 at 05:35:18PM +0530, Rakuram Eswaran wrote:
> Fix kernel-doc warnings in tcp_lp.c by adding missing parameter
> descriptions for tcp_lp_cong_avoid() and tcp_lp_pkts_acked() when
> building with W=1.
> 
> Also replace invalid URLs in the file header comment with the currently
> valid links to the TCP-LP paper and implementation page.
> 
> No functional changes.
> 
> Signed-off-by: Rakuram Eswaran <rakuram.e96@...il.com>
> ---
> Below W=1 build warnings:
> net/ipv4/tcp_lp.c:121 function parameter 'ack' not described in 'tcp_lp_cong_avoid'
> net/ipv4/tcp_lp.c:121 function parameter 'acked' not described in 'tcp_lp_cong_avoid'
> net/ipv4/tcp_lp.c:271 function parameter 'sample' not described in 'tcp_lp_pkts_acked'
> 
> The new URLs were verified through archive.org to confirm they match
> the content of the original references.
> ---
>  net/ipv4/tcp_lp.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/tcp_lp.c b/net/ipv4/tcp_lp.c
> index 52fe17167460fc433ec84434795f7cbef8144767..976b56644a8a746946e5028dcb054e4c3e249680 100644
> --- a/net/ipv4/tcp_lp.c
> +++ b/net/ipv4/tcp_lp.c
> @@ -23,9 +23,9 @@
>   * Original Author:
>   *   Aleksandar Kuzmanovic <akuzma@...thwestern.edu>
>   * Available from:
> - *   http://www.ece.rice.edu/~akuzma/Doc/akuzma/TCP-LP.pdf
> + *   https://users.cs.northwestern.edu/~akuzma/doc/TCP-LP-ToN.pdf

It's not important, but FTR, I notice that these
seem to be different versions of the same paper.

>   * Original implementation for 2.4.19:
> - *   http://www-ece.rice.edu/networks/TCP-LP/
> + *   https://users.cs.northwestern.edu/~akuzma/rice/TCP-LP/linux/tcp-lp-linux.htm

It's probably not important, but I think the following would
be a better drop-in replacement. That said, perhaps your choice
is a better one for the purposes of the comment above.

   https://users.cs.northwestern.edu/~akuzma/rice/TCP-LP/

That notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>

...