linux-kernel - Re: [PATCH v2 2/2] media: chips-media: wave5: Process ready frames when CMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5d17fc824ac7091e63f9d1d9ed7c0666994089e.camel@collabora.com>
Date: Tue, 28 Oct 2025 16:42:28 +0000
From: Nicolas Dufresne <nicolas.dufresne@...labora.com>
To: Brandon Brnich <b-brnich@...com>, Nas Chung <nas.chung@...psnmedia.com>,
  Jackson Lee <jackson.lee@...psnmedia.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, 	linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Darren Etheridge <detheridge@...com>
Subject: Re: [PATCH v2 2/2] media: chips-media: wave5: Process ready frames
 when CMD_STOP sent to Encoder

Le mardi 21 octobre 2025 à 15:46 -0500, Brandon Brnich a écrit :
> CMD_STOP being sent to encoder before last job is executed by device_run
> can lead to an occasional dropped frame. Ensure that remaining ready
> buffers are drained by making a call to v4l2_m2m_try_schedule.
> 
> Signed-off-by: Brandon Brnich <b-brnich@...com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
>  drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> index 0a2eab372913..7ee77c9a30c0 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> @@ -649,6 +649,8 @@ static int wave5_vpu_enc_encoder_cmd(struct file *file,
> void *fh, struct v4l2_en
>  
>  		m2m_ctx->last_src_buf = v4l2_m2m_last_src_buf(m2m_ctx);
>  		m2m_ctx->is_draining = true;
> +
> +		v4l2_m2m_try_schedule(m2m_ctx);
>  		break;
>  	case V4L2_ENC_CMD_START:
>  		break;

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)