linux-kernel - [PATCH] bus: arm-cci: Fix device node leak in cci_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251028171824.2074625-1-visitorckw@gmail.com>
Date: Tue, 28 Oct 2025 17:18:24 +0000
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: akpm@...ux-foundation.org,
	lpieralisi@...nel.org,
	nico@...xnic.net
Cc: jserv@...s.ncku.edu.tw,
	marscheng@...gle.com,
	wllee@...gle.com,
	linux-kernel@...r.kernel.org,
	Kuan-Wei Chiu <visitorckw@...il.com>
Subject: [PATCH] bus: arm-cci: Fix device node leak in cci_probe_ports()

The coccicheck tool reported the following warning:

./drivers/bus/arm-cci.c:458:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 465.

The for_each_available_child_of_node() loop increments the reference
count of the device node. A call to of_node_put() is required before
breaking out of the loop to avoid a reference leak.

Add the missing of_node_put() call to fix the leak.

Fixes: ed69bdd8fd9b ("drivers: bus: add ARM CCI support")
Signed-off-by: Kuan-Wei Chiu <visitorckw@...il.com>
---
Compile test only.

 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
 
 		i = nb_ace + nb_ace_lite;
 
-		if (i >= nb_cci_ports)
+		if (i >= nb_cci_ports) {
+			of_node_put(cp);
 			break;
+		}
 
 		if (of_property_read_string(cp, "interface-type",
 					&match_str)) {
-- 
2.51.1.851.g4ebd6896fd-goog