linux-kernel - Re: [PATCH net-next v2 3/5] psp: add stats from psp spec to driver facing api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251028103001.7cafeb03@kernel.org>
Date: Tue, 28 Oct 2025 10:30:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Daniel Zahka <daniel.zahka@...il.com>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Simon Horman
 <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>, Boris Pismenny
 <borisp@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>, Mark Bloch
 <mbloch@...dia.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/5] psp: add stats from psp spec to driver
 facing api

On Tue, 28 Oct 2025 10:02:16 +0100 Paolo Abeni wrote:
> This makes static checker unhappy:
> 
> /home/cocci/testing/include/net/psp/types.h:167:6-18: WARNING use
> flexible-array member instead
> (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> 
> I think/guess the warning could be avoided using something alike the
> following (completely untested!!!):

It's not a VLA, it's an end marker for calculating offsets.
The patch is fine, we should have added in the commit msg that the
false positive from cocci is expected.