linux-kernel - Re: [PATCH v7 0/2] Decouple max/min_pclk_khz check from constant display feats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6ce2b26-d941-4620-9544-e72d1d3d0d73@ti.com>
Date: Tue, 28 Oct 2025 08:58:02 +0530
From: Swamil Jain <s-jain1@...com>
To: <aradhya.bhatia@...ux.dev>, <devarsht@...com>, <mripard@...nel.org>,
        <tomi.valkeinen@...asonboard.com>, <jyri.sarha@....fi>,
        <maarten.lankhorst@...ux.intel.com>, <simona@...ll.ch>,
        <airlied@...il.com>, <tzimmermann@...e.de>, <h-shenoy@...com>
CC: <praneeth@...com>, <u-kumar1@...com>, <vigneshr@...com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 0/2] Decouple max/min_pclk_khz check from constant
 display feats



On 28-10-2025 02:56, Swamil Jain wrote:
> In an effort to make the existing compatibles more usable, we are
> removing the max/min_pclk_khz form dispc_features structure and doing
> the supported pixel clock checks using clk_round_rate().
> 
> Changes are fully backwards compatible.
> 
> - Remove max/min_pclk_khz and use clk_round_rate to validate modes
> - Skip OLDI mode validate through dispc_vp_mode_valid and add
>    mode_valid hook to validate modes for OLDI bridge in tidss_oldi.c
> 
> ---

NACK. I will resend v7 with some modifications in the cover letter.

Regards,
Swamil> Changelog v6->v7
> - Remove both max/min_pclk_khz as suggested by Tomi
> - Use mode_valid() instead of atomic_check()
> - Squash patches v6 PATCH 1/3 and PATCH 2/3 which is a fix to OLDI
>    series[1]
> - Minor fixes in commit message
> - Update comments to include more reasoning to add Fixes tag to
>    Patch v7 2/2
> 
> [1]: https://lore.kernel.org/all/20250528122544.817829-1-aradhya.bhatia@linux.dev/
> 
> v6 patch link:
> https://lore.kernel.org/all/20250911110715.2873596-1-s-jain1@ti.com/
> 
> Changelog v5->v6
> - Drop caching logic
> - Add comments for tolerance value
>    (We are targeting another series for reducing tolerance value)
> - Minor fixes in commit message
> 
> v5 patch link:
> https://lore.kernel.org/all/20250819192113.2420396-1-s-jain1@ti.com/
> 
> Changelog v4->v5
> - Rename is_oldi_vp[] to is_ext_vp_clk[]
> - Store both pixel clock round_rate and attempted_rate to reduce
>    clk_round_rate() calls while validating modes
> - Code changes suggested by Tomi[2]
> - Minor fixes in comments and commit message
> 
> [2]: https://lore.kernel.org/all/8cd9d1c4-2e9f-4766-b224-21925c4f991d@ideasonboard.com/
> 
> v4 patch link:
> https://lore.kernel.org/all/20250704094851.182131-1-j-choudhary@ti.com/
> 
> Changelog v3->v4:
> - Minor cosmetic fixes in code, comments and commit message
> - Pick up R-by and add Fixes tag
> 
> v3 patch link:
> https://lore.kernel.org/all/20250701095541.190422-1-j-choudhary@ti.com/
> 
> Changelog v2->v3:
> - Add changes for OLDI
> - Rename max_pclk as it is misleading
> - Change commit message to make it more appropriate
> - Drop unnecessary zero initialization
> 
> v2 patch link:
> https://lore.kernel.org/all/20250618100509.20386-1-j-choudhary@ti.com/
> 
> Changelog v1->v2:
> - Rebase it on linux-next after OLDI support series as all of its
>    patches are reviewed and tested and it touches one of the functions
>    used.
>    
> v1 patch link:
> https://lore.kernel.org/all/20250618075804.139844-1-j-choudhary@ti.com/
> 
> ---
> Jayesh Choudhary (2):
>    drm/tidss: Remove max_pclk_khz and min_pclk_khz from tidss display
>      features
>    drm/tidss: Move OLDI mode validation to OLDI bridge mode_valid hook
> 
>   drivers/gpu/drm/tidss/tidss_dispc.c | 87 +++++++++++------------------
>   drivers/gpu/drm/tidss/tidss_dispc.h |  3 -
>   drivers/gpu/drm/tidss/tidss_drv.h   |  2 +
>   drivers/gpu/drm/tidss/tidss_oldi.c  | 21 +++++++
>   4 files changed, 55 insertions(+), 58 deletions(-)
>