linux-kernel - Re: [PATCH v5 1/2] dma-mapping: benchmark: Restore padding to ensure uABI remained consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4wy2B7=KwLfODySky+FADkLZYowWCNm28FBmri_Opv7ZQ@mail.gmail.com>
Date: Wed, 29 Oct 2025 03:57:59 +0800
From: Barry Song <21cnbao@...il.com>
To: Qinxin Xia <xiaqinxin@...wei.com>
Cc: m.szyprowski@...sung.com, robin.murphy@....com, prime.zeng@...wei.com, 
	fanghao11@...wei.com, linux-kernel@...r.kernel.org, linuxarm@...wei.com, 
	wangzhou1@...ilicon.com, stable@...r.kernel.org
Subject: Re: [PATCH v5 1/2] dma-mapping: benchmark: Restore padding to ensure
 uABI remained consistent

On Tue, Oct 28, 2025 at 8:09 PM Qinxin Xia <xiaqinxin@...wei.com> wrote:
>
> The padding field in the structure was previously reserved to
> maintain a stable interface for potential new fields, ensuring
> compatibility with user-space shared data structures.
> However,it was accidentally removed by tiantao in a prior commit,
> which may lead to incompatibility between user space and the kernel.
>
> This patch reinstates the padding to restore the original structure
> layout and preserve compatibility.
>
> Fixes: 8ddde07a3d28 ("dma-mapping: benchmark: extract a common header file for map_benchmark definition")

It would be preferable to include the following as well:

Reported-by: Barry Song <baohua@...nel.org>
Closes: https://lore.kernel.org/lkml/CAGsJ_4waiZ2+NBJG+SCnbNk+nQ_ZF13_Q5FHJqZyxyJTcEop2A@mail.gmail.com/

> Cc: stable@...r.kernel.org
> Acked-by: Barry Song <baohua@...nel.org>
> Signed-off-by: Qinxin Xia <xiaqinxin@...wei.com>

Thank you. We also need to include Jonathan’s tag[1]:

Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

[1] https://lore.kernel.org/lkml/20250616105318.00001132@huawei.com/

I assume Marek can assist with adding those tags when you apply the patch?

Thanks
Barry