linux-kernel - Re: accel/amdxdna: Fix incorrect command state for timed out job

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2cf67a4-6795-d743-e90b-db10f636db2e@amd.com>
Date: Tue, 28 Oct 2025 14:00:12 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Markus Elfring <Markus.Elfring@....de>, <dri-devel@...ts.freedesktop.org>,
	Jeffrey Hugo <quic_jhugo@...cinc.com>, Maciej Falkowski
	<maciej.falkowski@...ux.intel.com>, Oded Gabbay <ogabbay@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, Mario Limonciello
	<mario.limonciello@....com>, Max Zhen <max.zhen@....com>, Sonal Santan
	<sonal.santan@....com>
Subject: Re: accel/amdxdna: Fix incorrect command state for timed out job


On 10/28/25 13:43, Markus Elfring wrote:
>>>> When a command times out, mark it as ERT_CMD_STATE_TIMEOUT. Any other
>>>> commands that are canceled due to this timeout should be marked as
>>>> ERT_CMD_STATE_ABORT.
>>> Would it become helpful to use additional labels for the same state settings?
>>> https://elixir.bootlin.com/linux/v6.18-rc3/source/drivers/accel/amdxdna/aie2_ctx.c#L197-L226
>> I do not fully understand your comment. Could you explain more?
> Do you propose to use the same state settings in a few if branches?
What are the same state settings?
> How do you think about to avoid duplicate statements accordingly?

What are the duplicate statements?

Sorry that I am still a little confused.


The code change is to distinguish between the job which is  timed out 
and the job is aborted.

Thanks,

Lizhi

>
> Regards,
> Markus