linux-kernel - Re: [PATCH v4 05/24] smb: move some duplicate definitions to common/smb1pdu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd8zuJsy5FZxsEQtPCm1OqJ6Usr-6CPkVgoRPYnX3NiQ9g@mail.gmail.com>
Date: Tue, 28 Oct 2025 13:02:45 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev>
Cc: sfrench@...ba.org, smfrench@...il.com, linkinjeon@...ba.org, 
	christophe.jaillet@...adoo.fr, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH v4 05/24] smb: move some duplicate definitions to common/smb1pdu.h

On Tue, Oct 28, 2025 at 12:58 PM ChenXiaoSong
<chenxiaosong.chenxiaosong@...ux.dev> wrote:
>
> Would it be harder to maintain if only part of the definitions are moved?
>
> Moving the related definitions together would make maintenance easier,
> that's just my personal opinion.
Please check Steve's reply on another mail thread.
If you think it looks weird, don't move them.

>
> On 10/28/25 11:42 AM, Namjae Jeon wrote:
> > On Mon, Oct 27, 2025 at 4:15 PM <chenxiaosong.chenxiaosong@...ux.dev> wrote:
> >>
> >> From: ChenXiaoSong <chenxiaosong@...inos.cn>
> >>
> >> In order to maintain the code more easily, move duplicate definitions to
> >> new common header file.
> >>
> >> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
> >> Suggested-by: Namjae Jeon <linkinjeon@...nel.org>
> > ksmbd does not use all smb1 pdus. Instead of moving all smb1 definitions,
> > move the ones ksmbd uses to smb1pdu.h.
> > Thanks.
>
> --
> Thanks,
> ChenXiaoSong.
>