linux-kernel - Re: [PATCH] fbdev: atyfb: Check if pll_ops->init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <879b9106-75c9-41a5-b0bc-b82e0bd30650@gmx.de>
Date: Tue, 28 Oct 2025 22:29:19 +0100
From: Helge Deller <deller@....de>
To: Daniel Palmer <daniel@...f.com>, linux-fbdev@...r.kernel.org
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: atyfb: Check if pll_ops->init_pll failed

On 10/24/25 11:37, Daniel Palmer wrote:
> Actually check the return value from pll_ops->init_pll()
> as it can return an error.
> 
> If the card's BIOS didn't run because it's not the primary VGA card
> the fact that the xclk source is unsupported is printed as shown
> below but the driver continues on regardless and on my machine causes
> a hard lock up.
> 
> [   61.470088] atyfb 0000:03:05.0: enabling device (0080 -> 0083)
> [   61.476191] atyfb: using auxiliary register aperture
> [   61.481239] atyfb: 3D RAGE XL (Mach64 GR, PCI-33) [0x4752 rev 0x27]
> [   61.487569] atyfb: 512K SGRAM (1:1), 14.31818 MHz XTAL, 230 MHz PLL, 83 Mhz MCLK, 63 MHz XCLK
> [   61.496112] atyfb: Unsupported xclk source:  5.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Daniel Palmer <daniel@...f.com>
> ---
>   drivers/video/fbdev/aty/atyfb_base.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)

applied.

Thanks!
Helge