| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20251028-camss-8x39-vbif-v7-0-91ee8becda85@apitzsch.eu>
Date: Tue, 28 Oct 2025 22:30:41 +0100
From: André Apitzsch via B4 Relay <devnull+git.apitzsch.eu@...nel.org>
To: Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Vincent Knecht <vincent.knecht@...loo.org>,
André Apitzsch <git@...tzsch.eu>,
Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
Krzysztof Kozlowski <krzk@...nel.org>
Subject: [PATCH v7 0/4] Add CAMSS support for MSM8939
This series adds CAMSS support for MSM8939. It's mostly identical to
MSM8916, except for some clocks and an additional CSI.
To fix black stripes across sensor output, and garbage in CSID TPG
output, 2 VFE VBIF register settings are needed. So the 2nd patch adds
helper functions to do just that.
Patch 1: documents qcom,msm8939-camss DT bindings
Patch 2: adds helper for VFE VBIF settings
Patch 3: adds CAMSS_8x39 version in CAMSS driver
Patch 4: adds camss and cci in msm8939.dtsi
Signed-off-by: Vincent Knecht <vincent.knecht@...loo.org>
[André: Apply reviewer comments]
Signed-off-by: André Apitzsch <git@...tzsch.eu>
---
Changes in v7:
- Fix revision (previous submission was wrongly labelled v1)
- Pick up tags
- Rebase on latest next/master
- Link to v6: https://lore.kernel.org/r/20250908-camss-8x39-vbif-v1-0-f198c9fd0d4d@apitzsch.eu
Changes in v6 (was wrongly labelled v1):
- Move bindings patch to the beginning
- Make the order of {reg, clock, interrupt} items the same as in 8916 +
append additional items
- Drop R-b tags from bindings and dts patches as order of items was
changed
- Link to v5: https://lore.kernel.org/r/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org
Changes in v5:
- Patch 1: no change
- Patch 2: no change
- Patch 3: (bindings)
- Fix alphanumerical ordering wrt. underscore (Vladimir)
- Add 1.2V mention to vdda-supply description (Vladimir)
- Correct vdda-supply regulator name for 1.2V in example
- Add empty line between properties and child node (Vladimir)
- Remove clock-lanes property in example (Vladimir)
- Patch 4: (dtsi)
- Apply ordering and isp node unit address changes from patch 3.
- Link to v4: https://lore.kernel.org/r/20250602-camss-8x39-vbif-v4-0-32c277d8f9bf@mailoo.org
Changes in v4:
- Picked up tags
- Patch 1:
- Fix alignment to match opening parenthesis (Bryan)
- Patch 2: no change
- Patch 3:
- Wrap line at 80 chars (Krzysztof)
- Patch 4: no change
- Link to v3: https://lore.kernel.org/r/20250530-camss-8x39-vbif-v3-0-fc91d15bb5d6@mailoo.org
Changes in v3:
- Patch 1:
- Use braces around multiline (Bryan)
- Rename vfe_vbif_reg_write to vfe_vbif_write_reg (Bryan)
- Get rid of switch block on CAMSS version (Bryan)
- Patch 2:
- Get rid of switch block on CAMSS version (Bryan)
- Patch 3: no change
- Patch 4: no change
- Tried to get rid of CCI camss_ahb but this resulted in device
freeze+reboot (Konrad)
- Link to v2: https://lore.kernel.org/r/20250525-camss-8x39-vbif-v2-0-6d3d5c5af456@mailoo.org
Changes in v2:
- Patch 1:
- Fix devm_platform_ioremap_resource_byname line to not end with
opening parenthesis (media-ci/1-checkpatch)
- Move camss-vfe-4-1.c handling of VBIF previously in patch 2 here
(Dmitry)
- Patch 2:
- Declare regulators in PHY entries, not CSID ones (Bryan)
- Patch 3: (bindings)
- Fix bindings checks for new errors (Rob)
- Fix properties ordering, code-style and example (Krzysztof)
- Sort reg-names, clock-names and interrupt-names alphanumerically (Bryan)
- Patch 4: (dtsi)
- Move #address/#size cells before status (Konrad)
- Aligned CCI with msm8916, thus removing ispif_ahb mention (Konrad)
If "camss_ahb should be unnecessary", it's still required by qcom,i2c-cci.yaml
- Link to v1: https://lore.kernel.org/r/20250520-camss-8x39-vbif-v1-0-a12cd6006af9@mailoo.org
---
Vincent Knecht (4):
media: dt-bindings: Add qcom,msm8939-camss
media: qcom: camss: vfe: Add VBIF setting support
media: qcom: camss: Add support for MSM8939
arm64: dts: qcom: msm8939: Add camss and cci
.../bindings/media/qcom,msm8939-camss.yaml | 254 +++++++++++++++++++++
arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi | 4 +
arch/arm64/boot/dts/qcom/msm8939.dtsi | 146 ++++++++++++
drivers/media/platform/qcom/camss/Makefile | 1 +
drivers/media/platform/qcom/camss/camss-csiphy.c | 1 +
drivers/media/platform/qcom/camss/camss-ispif.c | 8 +-
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 12 +
drivers/media/platform/qcom/camss/camss-vfe-vbif.c | 31 +++
drivers/media/platform/qcom/camss/camss-vfe-vbif.h | 19 ++
drivers/media/platform/qcom/camss/camss-vfe.c | 10 +
drivers/media/platform/qcom/camss/camss-vfe.h | 3 +
drivers/media/platform/qcom/camss/camss.c | 157 +++++++++++++
drivers/media/platform/qcom/camss/camss.h | 1 +
13 files changed, 645 insertions(+), 2 deletions(-)
---
base-commit: f7d2388eeec24966fc4d5cf32d706f0514f29ac5
change-id: 20250517-camss-8x39-vbif-975ff5819198
Best regards,
--
André Apitzsch <git@...tzsch.eu>
Powered by blists - more mailing lists