linux-kernel - [PATCH] mfd: altera-sysmgr: Fix device reference leak in altr_sysmgr_regmap_lookup_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251028041042.48874-1-linmq006@gmail.com>
Date: Tue, 28 Oct 2025 12:10:42 +0800
From: Miaoqian Lin <linmq006@...il.com>
To: Lee Jones <lee@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Thor Thayer <thor.thayer@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Cc: linmq006@...il.com,
	stable@...r.kernel.org
Subject: [PATCH] mfd: altera-sysmgr: Fix device reference leak in altr_sysmgr_regmap_lookup_by_phandle

driver_find_device_by_of_node() calls driver_find_device(), which calls
get_device(). get_device() increments the device's reference count,
so driver_find_device_by_of_node() returns a device
with its reference count incremented.
We need to release this reference after usage to avoid a reference leak.

Add put_device(dev) after dev_get_drvdata() to fix the reference leak.

Found via static analysis.

Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
Cc: stable@...r.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
 drivers/mfd/altera-sysmgr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c
index fb5f988e61f3..cb66b2fff536 100644
--- a/drivers/mfd/altera-sysmgr.c
+++ b/drivers/mfd/altera-sysmgr.c
@@ -116,6 +116,7 @@ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np,
 		return ERR_PTR(-EPROBE_DEFER);
 
 	sysmgr = dev_get_drvdata(dev);
+	put_device(dev);
 
 	return sysmgr->regmap;
 }
-- 
2.39.5 (Apple Git-154)