linux-kernel - Re: [PATCH] ptp: guard ptp_clock_gettime() if neither gettimex64 nor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251028161309.596beef2@kernel.org>
Date: Tue, 28 Oct 2025 16:13:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...gle.com>, Vadim Fedorenko
 <vadim.fedorenko@...ux.dev>
Cc: richardcochran@...il.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, junjie.cao@...el.com, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, pabeni@...hat.com,
 syzbot+c8c0e7ccabd456541612@...kaller.appspotmail.com,
 syzkaller-bugs@...glegroups.com, thostet@...gle.com
Subject: Re: [PATCH] ptp: guard ptp_clock_gettime() if neither gettimex64
 nor

On Tue, 28 Oct 2025 15:51:50 +0000 Kuniyuki Iwashima wrote:
> From: Richard Cochran <richardcochran@...il.com>
> Date: Tue, 28 Oct 2025 07:09:41 -0700
> > On Tue, Oct 28, 2025 at 05:51:43PM +0800, Junjie Cao wrote:  
> > > Syzbot reports a NULL function pointer call on arm64 when
> > > ptp_clock_gettime() falls back to ->gettime64() and the driver provides
> > > neither ->gettimex64() nor ->gettime64(). This leads to a crash in the
> > > posix clock gettime path.  
> > 
> > Drivers must provide a gettime method.
> > 
> > If they do not, then that is a bug in the driver.  
> 
> AFAICT, only GVE does not have gettime() and settime(), and
> Tim (CCed) was preparing a fix and mostly ready to post it.

cc: Vadim who promised me a PTP driver test :) Let's make sure we
tickle gettime/setting in that test..