| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20251027-cpu_cluster_component_pm-v1-10-31355ac588c2@oss.qualcomm.com>
Date: Mon, 27 Oct 2025 23:28:12 -0700
From: Yuanfang Zhang <yuanfang.zhang@....qualcomm.com>
To: Suzuki K Poulose <suzuki.poulose@....com>,
Mike Leach <mike.leach@...aro.org>,
James Clark <james.clark@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Leo Yan <leo.yan@...ux.dev>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: kernel@....qualcomm.com, coresight@...ts.linaro.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
Yuanfang Zhang <yuanfang.zhang@....qualcomm.com>
Subject: [PATCH 10/12] coresight-tmc: Handle delayed probe for CPU cluster
TMC
Delay probe the cpu cluster TMC when all CPUs of this cluster are
offline, re-probe the funnel when any CPU in the cluster comes online.
Key changes:
- Introduce a global list to track delayed TMCs waiting for CPU online.
- Add CPU hotplug callback to retry registration when the CPU comes up.
Signed-off-by: Yuanfang Zhang <yuanfang.zhang@....qualcomm.com>
---
drivers/hwtracing/coresight/coresight-tmc-core.c | 59 +++++++++++++++++++++++-
drivers/hwtracing/coresight/coresight-tmc.h | 4 ++
2 files changed, 61 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
index 685a64d8ba1b5df4cff91694eee45c6d6a147bc1..7274ad07c2b20d2aa6e568b4bab0fbb57e331ab8 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-core.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
@@ -36,6 +36,9 @@
DEFINE_CORESIGHT_DEVLIST(etb_devs, "tmc_etb");
DEFINE_CORESIGHT_DEVLIST(etf_devs, "tmc_etf");
DEFINE_CORESIGHT_DEVLIST(etr_devs, "tmc_etr");
+static LIST_HEAD(tmc_delay_probe);
+static enum cpuhp_state hp_online;
+static DEFINE_SPINLOCK(delay_lock);
int tmc_wait_for_tmcready(struct tmc_drvdata *drvdata)
{
@@ -1028,6 +1031,8 @@ static int __tmc_probe(struct device *dev, struct resource *res)
if (!drvdata->cpumask)
return -EINVAL;
+ drvdata->dev = dev;
+
cpus_read_lock();
for_each_cpu(cpu, drvdata->cpumask) {
ret = smp_call_function_single(cpu,
@@ -1035,11 +1040,16 @@ static int __tmc_probe(struct device *dev, struct resource *res)
if (!ret)
break;
}
- cpus_read_unlock();
+
if (ret) {
+ scoped_guard(spinlock, &delay_lock)
+ list_add(&drvdata->link, &tmc_delay_probe);
+ cpus_read_unlock();
ret = 0;
goto out;
}
+
+ cpus_read_unlock();
} else {
tmc_init_hw_config(drvdata);
}
@@ -1104,8 +1114,12 @@ static void __tmc_remove(struct device *dev)
misc_deregister(&drvdata->miscdev);
if (drvdata->crashdev.fops)
misc_deregister(&drvdata->crashdev);
- if (drvdata->csdev)
+ if (drvdata->csdev) {
coresight_unregister(drvdata->csdev);
+ } else {
+ scoped_guard(spinlock, &delay_lock)
+ list_del(&drvdata->link);
+ }
}
static void tmc_remove(struct amba_device *adev)
@@ -1224,14 +1238,55 @@ static struct platform_driver tmc_platform_driver = {
},
};
+static int tmc_online_cpu(unsigned int cpu)
+{
+ struct tmc_drvdata *drvdata, *tmp;
+ int ret;
+
+ spin_lock(&delay_lock);
+ list_for_each_entry_safe(drvdata, tmp, &tmc_delay_probe, link) {
+ if (cpumask_test_cpu(cpu, drvdata->cpumask)) {
+ list_del(&drvdata->link);
+
+ spin_unlock(&delay_lock);
+ ret = pm_runtime_resume_and_get(drvdata->dev);
+ if (ret < 0)
+ return 0;
+
+ tmc_init_hw_config(drvdata);
+ tmc_clear_self_claim_tag(drvdata);
+ tmc_add_coresight_dev(drvdata->dev);
+ pm_runtime_put(drvdata->dev);
+ spin_lock(&delay_lock);
+ }
+ }
+ spin_unlock(&delay_lock);
+ return 0;
+}
+
static int __init tmc_init(void)
{
+ int ret;
+
+ ret = cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN,
+ "arm/coresight-tmc:online",
+ tmc_online_cpu, NULL);
+
+ if (ret > 0)
+ hp_online = ret;
+ else
+ return ret;
+
return coresight_init_driver("tmc", &tmc_driver, &tmc_platform_driver, THIS_MODULE);
}
static void __exit tmc_exit(void)
{
coresight_remove_driver(&tmc_driver, &tmc_platform_driver);
+ if (hp_online) {
+ cpuhp_remove_state_nocalls(hp_online);
+ hp_online = 0;
+ }
}
module_init(tmc_init);
module_exit(tmc_exit);
diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
index f5c76ca2dc9733daa020b79b1dcfc495045a2618..29ccf0b7f4fe90a93d926a2e273950bce9834336 100644
--- a/drivers/hwtracing/coresight/coresight-tmc.h
+++ b/drivers/hwtracing/coresight/coresight-tmc.h
@@ -246,6 +246,8 @@ struct tmc_resrv_buf {
* @cpumask: CPU mask representing the CPUs related to this TMC.
* @devid: TMC variant ID inferred from the device configuration register.
* @desc_name: Name to be used while creating crash interface.
+ * @dev: pointer to the device associated with this TMC.
+ * @link: link to the delay_probed list.
*/
struct tmc_drvdata {
struct clk *atclk;
@@ -279,6 +281,8 @@ struct tmc_drvdata {
struct cpumask *cpumask;
u32 devid;
const char *desc_name;
+ struct device *dev;
+ struct list_head link;
};
struct etr_buf_operations {
--
2.34.1
Powered by blists - more mailing lists