linux-kernel - Re: [PATCH v3] media: v4l2-ctrls: add full AV1 profile validation in validate_av1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKPKb89WkMmTt2atSg-J0HhY08dapHGLmuOJDYQRWWz5hAyhdA@mail.gmail.com>
Date: Tue, 28 Oct 2025 12:05:13 +0530
From: opensource india <opensource206@...il.com>
To: Hans Verkuil <hverkuil+cisco@...nel.org>
Cc: jc@...esim.co.uk, mchehab@...nel.org, hverkuil@...nel.org, 
	ribalda@...omium.org, laurent.pinchart@...asonboard.com, yunkec@...gle.com, 
	sakari.ailus@...ux.intel.com, james.cowgill@...ize.com, 
	Nicolas Dufresne <nicolas.dufresne@...labora.com>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] media: v4l2-ctrls: add full AV1 profile validation in validate_av1_sequence()

Hi Hans,
On Mon, Oct 27, 2025 at 9:24 PM Hans Verkuil <hverkuil+cisco@...nel.org> wrote:
>
> Always compile v4l2-compliance from the git repo https://git.linuxtv.org/v4l-utils.git/
> 1.31 is old, and it is important to test with the latest version since it will be kept
> in sync with the head of the media-committers git repo.

Apologies. i upgraded my v4l-utils repo to recent(version 1.33) and i
can see the error now

>
> Debugging a bit in validate_av1_sequence() shows it fails here:
>
>         /* 4. Profile-specific rules */
>         switch (s->seq_profile) {
>         case 0:
>                 /* Profile 0: only 8/10-bit, subsampling=4:2:0 (sx=1, sy=1) */
>                 if (s->bit_depth != 8 && s->bit_depth != 10)
>                         return -EINVAL;
>                 if (!(sx && sy))
>                         return -EINVAL;
>                 ^^^^^^^^^^^^^^^^ This is the test that fails the validation
>                 break;
>
> Regards,
>
>         Hans

yes. subsampling flags are set to 0 , which are not allowed as per our code.
tested v4l2-compliance successfully with below fix. please review

https://lore.kernel.org/linux-media/20251028062623.12700-1-opensource206@gmail.com/T/#u

Regards,
Pavan