linux-kernel - Re: [PATCH v2] sched/fair: Fix non-empty throttled_limbo_list warning in tg_throttle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b495827a-0ee8-512a-edb8-cd79c84d5a6a@gmail.com>
Date: Tue, 28 Oct 2025 15:31:37 +0800
From: Hao Jia <jiahao.kernel@...il.com>
To: Aaron Lu <ziqianlu@...edance.com>
Cc: mingo@...hat.com, peterz@...radead.org, mingo@...nel.org,
 juri.lelli@...hat.com, vincent.guittot@...aro.org, dietmar.eggemann@....com,
 rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
 vschneid@...hat.com, kprateek.nayak@....com, linux-kernel@...r.kernel.org,
 Hao Jia <jiahao1@...iang.com>
Subject: Re: [PATCH v2] sched/fair: Fix non-empty throttled_limbo_list warning
 in tg_throttle_down()



On 2025/10/27 20:02, Aaron Lu wrote:

>>    *
>> + * THROTTLE - invoke in throttle_cfs_rq_work() to ensure task dequeue
>> + *            during throttling, and in tg_unthrottle_up() to ensure
>> + *            task enqueue during unthrottling.
> 
> Thanks for adding the comment for dequeue_throttle. One nit is:
> dequeue_throttle is used for time accounting purpose so it would be
> better if you can make that clear, maybe something like this:
> 
> invoked in throttle_cfs_rq_work() during throttle for accounting
> purpose, and in tg_unthrottle_up() to avoid throttling when enqueuing
> tasks.

Thanks, will do it.

Thanks,
Hao