| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aQBxdDzFkR9CYpSN@fedora> Date: Tue, 28 Oct 2025 08:32:04 +0100 From: José Expósito <jose.exposito89@...il.com> To: Louis Chauvet <louis.chauvet@...tlin.com> Cc: Haneen Mohammed <hamohammed.sa@...il.com>, Simona Vetter <simona@...ll.ch>, Melissa Wen <melissa.srw@...il.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Jonathan Corbet <corbet@....net>, victoria@...tem76.com, sebastian.wick@...hat.com, thomas.petazzoni@...tlin.com, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org Subject: Re: [PATCH 00/22] VKMS: Introduce multiple configFS attributes On Mon, Oct 27, 2025 at 04:53:03PM +0100, Louis Chauvet wrote: > > > Le 27/10/2025 à 16:22, José Expósito a écrit : > > Hey Louis, > > > > On Sat, Oct 18, 2025 at 04:01:00AM +0200, Louis Chauvet wrote: > > > VKMS have a wide range of options. The aim of this series is to introduce > > > many configfs attribute so VKMS can be used to test a wide range of > > > configurations. > > > > > > This series depends on [1] that should be applied soon. > > > > > > PATCH 1-13 are for configuring planes > > > - name > > > - rotation > > > - color encoding > > > - color range > > > - plane formats > > > - zpos > > > PATCH 14-19 are for configuring the connector > > > - type > > > - supported colorspace > > > - edid > > > PATCH 20-22 are to enable dynamic connectors > > > > > > [1]:https://lore.kernel.org/all/20251016175618.10051-1-jose.exposito89@gmail.com > > > > > > PS: Each pair of config/configfs patch are independant. I could > > > technically create ≈10 different series, but there will be a lot of > > > (trivial) conflicts between them. I will be happy to reordoer, split and > > > partially apply this series to help the review process. > > > > I just finished reviewing the series. > > Thanks a lot, I started to apply your suggestions (I agree to most of them). > > > Amazing work, thanks a lot for adding all of these new properties!! > > > > I'd like to see KUnit and IGT coverage to test coner cases and, since this > > is uAPI, to have a mechanishm to catch regressions without lots of manual > > testing. > > I started to add some Kunits for vkms_config.c, for the format parsing too. > > > Let's talk so we can start working on them on v2, I'll be able to help in > > that front if needed. > > I finish to apply your suggestions and I will send the v2 soon, so we can > discuss on the same ground. I think we can add a little bit of vkms_config.c > testing, but for vkms_configfs I need to see if we can mock configfs > interations from kunit tests. For vkms_configfs I find more convinient IGT than mocking in KUnit. It saves maintaining a bunch of mocking code and it is a good way to test end-to-end VKMS. Jose > Have a nice week, > Louis Chauvet > > > Best wishes, > > Jose > > > Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com> > > > --- > > > Louis Chauvet (22): > > > drm/vkms: Introduce config for plane name > > > drm/vkms: Introduce configfs for plane name > > > drm/vkms: Introduce config for plane rotation > > > drm/vkms: Introduce configfs for plane rotation > > > drm/vkms: Introduce config for plane color encoding > > > drm/vkms: Introduce configfs for plane color encoding > > > drm/vkms: Introduce config for plane color range > > > drm/vkms: Introduce configfs for plane color range > > > drm/vkms: Introduce config for plane format > > > drm/vkms: Introduce configfs for plane format > > > drm/vkms: Properly render plane using their zpos > > > drm/vkms: Introduce config for plane zpos property > > > drm/vkms: Introduce configfs for plane zpos property > > > drm/vkms: Introduce config for connector type > > > drm/vkms: Introduce configfs for connector type > > > drm/vkms: Introduce config for connector supported colorspace > > > drm/vkms: Introduce configfs for connector supported colorspace > > > drm/vkms: Introduce config for connector EDID > > > drm/vkms: Introduce configfs for connector EDID > > > drm/vkms: Store the enabled/disabled status for connector > > > drm/vkms: Allow to hot-add connectors > > > drm/vkms: Allows the creation of connector at runtime > > > > > > Documentation/gpu/vkms.rst | 42 +- > > > drivers/gpu/drm/vkms/tests/vkms_config_test.c | 18 + > > > drivers/gpu/drm/vkms/vkms_config.c | 183 ++++++ > > > drivers/gpu/drm/vkms/vkms_config.h | 524 +++++++++++++++ > > > drivers/gpu/drm/vkms/vkms_configfs.c | 893 +++++++++++++++++++++++++- > > > drivers/gpu/drm/vkms/vkms_connector.c | 137 +++- > > > drivers/gpu/drm/vkms/vkms_connector.h | 36 +- > > > drivers/gpu/drm/vkms/vkms_crtc.c | 11 +- > > > drivers/gpu/drm/vkms/vkms_drv.h | 6 +- > > > drivers/gpu/drm/vkms/vkms_output.c | 19 +- > > > drivers/gpu/drm/vkms/vkms_plane.c | 73 +-- > > > 11 files changed, 1865 insertions(+), 77 deletions(-) > > > --- > > > base-commit: b291e4f1a4951204ce858cd01801291d34962a33 > > > change-id: 20251017-vkms-all-config-bd0c2a01846f > > > prerequisite-message-id: 20251016175618.10051-1-jose.exposito89@...il.com > > > prerequisite-patch-id: 74083a8806b1f26d9b4cd2a5107c756b971c4d11 > > > prerequisite-patch-id: f982390487699921b625b413e8460d67ca7a74c9 > > > prerequisite-patch-id: 0afca639e43c8fbfea2af1bc395e489efc8e1f10 > > > prerequisite-patch-id: 6285108b2fd90d30d15d4cb4fdddfef953fad51b > > > prerequisite-patch-id: 2eacf5ad4f25f54a60958aa7a2df633d5642ce2f > > > prerequisite-patch-id: 81e98ac3aeb3b6128098ab7bab56d3446a3a2705 > > > prerequisite-patch-id: 973f94c4edb4a5822c84a57d4479ca40e9cf25de > > > prerequisite-patch-id: 0efbaf1b0e962a1c40bf5a744b5089d8be696f62 > > > prerequisite-patch-id: afa0cff94085e6ab216ffd9b99cd3dc882a0a687 > > > prerequisite-patch-id: 3561347f2b586392985a8e3af9ed1c5c7d3eefd5 > > > prerequisite-patch-id: 94030044ae8d404f7cdaed9137bddd59cfb22e79 > > > prerequisite-patch-id: a54b483797d5ffb7ce13b56a8943025181cd0d7a > > > prerequisite-patch-id: f148fe7f445cb42437e7e2ba8b59e7e0fd40da8b > > > prerequisite-patch-id: 1ef2045872843670c452816c5d6187b713c9258c > > > prerequisite-patch-id: 3b9963ea3ae3455ae15ee36b67042c06a2ef6006 > > > prerequisite-patch-id: 519ee42dfabb4de734e41e59bd07d7a723d810bb > > > > > > Best regards, > > > -- > > > Louis Chauvet <louis.chauvet@...tlin.com> > > > > > -- > -- > Louis Chauvet, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
Powered by blists - more mailing lists