linux-kernel - Re: [PATCH 1/2] dt-bindings: Input: Add Wacom W9000-series penabled touchscreens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251028-hairy-caped-pronghorn-88d9b8@kuoka>
Date: Tue, 28 Oct 2025 08:38:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hendrik Noack <hendrik-noack@....de>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-input@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Input: Add Wacom W9000-series penabled
 touchscreens

On Mon, Oct 27, 2025 at 10:25:34PM +0100, Hendrik Noack wrote:
> Add bindings for two Wacom W9007 variants which can be found in tablets.
> 
> Signed-off-by: Hendrik Noack <hendrik-noack@....de>
> ---
>  .../input/touchscreen/wacom,w9000-series.yaml | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,w9000-series.yaml

Filename matching compatible,

> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,w9000-series.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,w9000-series.yaml
> new file mode 100644
> index 000000000000..93579ae0297e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,w9000-series.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/wacom,w9000-series.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Wacom W9000-series penabled I2C touchscreen driver

Driver as Linux driver? if so, then drop.

> +
> +description:
> +  The W9000-series are penabled touchscreen controllers by Wacom.
> +
> +maintainers:
> +  - Hendrik Noack <hendrik-noack@....de>
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - wacom,w9007a_lt03
> +      - wacom,w9007a_v1

None of the compatibles use underscores. Please do not come up with
entirely different coding style than existing kernel.

Also, nothing explain here differences - not commit msg, not
description.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description:
> +      Optional regulator for the VDD digital voltage.
> +
> +  pdct-gpios:
> +    maxItems: 1
> +    description:
> +      Optional GPIO specifier for the touchscreen's pdct pin.
> +
> +  flash-mode-gpios:
> +    maxItems: 1
> +    description:
> +      Optional GPIO specifier for the touchscreen's flash-mode pin.
> +
> +  pen-inserted-gpios:
> +    maxItems: 1
> +    description:
> +      Optional GPIO specifier for the touchscreen's pen-insert pin.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      digitizer@56 {
> +        compatible = "wacom,wacom,w9007a_v1";
> +        reg = <0x56>;
> +        interrupt-parent = <&gpx3>;
> +        interrupts = <5 IRQ_TYPE_EDGE_RISING>;
> +
> +        vdd-supply = <&stylus_reg>;
> +
> +        pdct-gpios = <&gpd1 2 GPIO_ACTIVE_HIGH>;
> +        flash-mode-gpios = <&gpd1 3 GPIO_ACTIVE_HIGH>;
> +        pen-inserted-gpios = <&gpx0 0 GPIO_ACTIVE_LOW>;
> +
> +        touchscreen-x-mm = <262>;
> +        touchscreen-y-mm = <164>;

Never tested, after fixing compatible you will see errors. You need
unevaluatedProperties.

Best regards,
Krzysztof