linux-kernel - Re: [PATCH 1/2] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQCTBHZ2pQ1pTAnA@smile.fi.intel.com>
Date: Tue, 28 Oct 2025 11:55:16 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Antony Kurniawan Soemardi <linux@...nkusors.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-arm-msm@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: qcom-pm8xxx-xoadc: add support for reading
 channel labels

On Mon, Oct 27, 2025 at 05:29:16PM +0000, Antony Kurniawan Soemardi wrote:
> This allows user-space tools to identify ADC channels by name through
> the IIO sysfs interface.

...

> +static int pm8xxx_read_label(struct iio_dev *indio_dev,
> +			     struct iio_chan_spec const *chan, char *label)
> +{
> +	return sysfs_emit(label, "%s\n", chan->datasheet_name);
> +}

Hmm... In another thread there is a discussion on label vs. datasheet_name.
So, why datasheet name and not something that it's more reliable as a platform
description? As far as I understand there many mysterious ways of HW
engineering and how to connect available pins to something interesting. Even
datasheet names may be quite mislead on a certain platform (due to above).
I would expect this to come from DT or another platform description and user
space should rely on the information from _there_.

-- 
With Best Regards,
Andy Shevchenko