linux-kernel - Re: [PATCH] gfs2: document ip in __gfs2_holder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU6FanLe+b9RX=Lao2MQ2JOJU3JKNOsTTX3NUzNNzWfuAA@mail.gmail.com>
Date: Tue, 28 Oct 2025 11:07:48 +0100
From: Andreas Gruenbacher <agruenba@...hat.com>
To: Sukrut Heroorkar <hsukrut3@...il.com>
Cc: "open list:GFS2 FILE SYSTEM" <gfs2@...ts.linux.dev>, open list <linux-kernel@...r.kernel.org>, shuah@...nel.org, 
	david.hunter.linux@...il.com
Subject: Re: [PATCH] gfs2: document ip in __gfs2_holder_init kernel-doc comment

On Mon, Oct 27, 2025 at 12:01 PM Sukrut Heroorkar <hsukrut3@...il.com> wrote:
> Building with W=1 reports:
> Warning: fs/gfs2/glock.c:1248 function parameter 'ip' not described
> in '__gfs2_holder_init'
>
> The ip parameter was added when __gfs2_holder_init started saving the
> gfs2_glock_nq_init caller's return address to gh_ip. This makes it
> easier to backtrack which holder took the lock. Document @ip to silence
> this warning.
>
> Fixes: b016d9a84abd ("gfs2: Save ip from gfs2_glock_nq_init")
> Signed-off-by: Sukrut Heroorkar <hsukrut3@...il.com>
> ---
>  fs/gfs2/glock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 91d0afec4087..bc6f236b899c 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -1163,7 +1163,7 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number,
>   * @state: the state we're requesting
>   * @flags: the modifier flags
>   * @gh: the holder structure
> - *
> + * @ip: caller's return address for debugging
>   */
>
>  void __gfs2_holder_init(struct gfs2_glock *gl, unsigned int state, u16 flags,
> --
> 2.43.0
>

Applied, thanks.

Andreas