linux-kernel - Re: [PATCH] phy: ti: omap-usb2: Fix device node reference leak in omap_usb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQCYQ8NY3iaC4G_E@hovoldconsulting.com>
Date: Tue, 28 Oct 2025 11:17:39 +0100
From: Johan Hovold <johan@...nel.org>
To: Miaoqian Lin <linmq006@...il.com>
Cc: Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Roger Quadros <rogerq@...com>, linux-phy@...ts.infradead.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] phy: ti: omap-usb2: Fix device node reference leak in
 omap_usb2_probe

On Tue, Oct 28, 2025 at 02:25:06PM +0800, Miaoqian Lin wrote:
> In omap_usb2_probe(), of_parse_phandle() returns a device node with its
> reference count incremented. The caller is responsible for releasing this
> reference when the node is no longer needed.
> 
> Add of_node_put(control_node) after usage to fix the
> reference leak.
> 
> Found via static analysis.
> 
> Fixes: 478b6c7436c2 ("usb: phy: omap-usb2: Don't use omap_get_control_dev()")
> Cc: stable@...r.kernel.org

There should not be any need to backport this one.

> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Other than that, looks good:

Reviewed-by: Johan Hovold <johan@...nel.org>

Johan