linux-kernel - Re: [PATCH] ALSA: sound: Increase max size of components field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6596d39f91115567741add153eec5c476a85656.camel@opensource.cirrus.com>
Date: Tue, 28 Oct 2025 11:14:57 +0000
From: Maciej Strozek <mstrozek@...nsource.cirrus.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        patches@...nsource.cirrus.com, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: sound: Increase max size of components field

W dniu wto, 28.10.2025 o godzinie 09∶42 +0900, użytkownik Takashi
Sakamoto napisał:
> Hi,
> 
> On Mon, Oct 27, 2025 at 11:50:32AM +0000, Maciej Strozek wrote:
> > diff --git a/include/uapi/sound/asound.h
> > b/include/uapi/sound/asound.h
> > index c302698fb685..7d53f6da59e2 100644
> > --- a/include/uapi/sound/asound.h
> > +++ b/include/uapi/sound/asound.h
> > @@ -1069,7 +1069,12 @@ struct snd_ctl_card_info {
> >         unsigned char longname[80];
> >         unsigned char reserved_[16];
> >         unsigned char mixername[80];
> > -       unsigned char components[256];
> > +       unsigned char components[128];
> > +};
> 
> Any approach to change the result of 'sizeof(struct
> snd_ctl_card_info)'
> breaks ABI to userspace application. This is the reason that Jaroslav
> addresses to the new PCM ioctl command. Unless, the userspace
> application build with the UAPI header provided by the existing
> version
> of Linux kernel does not work as expected in your version of Linux
> kernel, in respect to the sound subsystem.
> 
Apologies for the confusion, the draft was based on the initial patch
that increased the size of the components, so this snippet is actually
bringing back the original size. This will not be present in V2.

> 
> Regards
> 
> Takashi Sakamoto

-- 
Regards,
Maciej