linux-kernel - Re: [PATCH 1/3] dt-bindings: vdec: Add binding document of Amlogic decoder accelerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <606da3b1-f042-4cc1-89d0-4feb257f032f@kernel.org>
Date: Tue, 28 Oct 2025 12:33:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zhentao Guo <zhentao.guo@...ogic.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: vdec: Add binding document of Amlogic
 decoder accelerator

On 28/10/2025 12:14, Zhentao Guo wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: amlogic,s4-vcodec-dec
>>> +
>>> +  reg:
>>> +    maxItems: 2
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: dosbus
>>> +      - const: dmcbus
>> Is "bus" really name of this in datasheet?
> No, it is not from the datasheet, in fact it was inherited from the
> older SOCs. Do you have any suggestions about this?

dos, dmc

>>> +
>>> +  interrupts:
>>> +    maxItems: 3
>>> +
>>> +  interrupt-names:
>>> +    items:
>>> +      - const: mailbox_0
>>> +      - const: mailbox_1
>>> +      - const: mailbox_2
>> Useless names, so just drop interrupt-names property.
> Yes, we don't need the interrupt names. I'll drop them.
>>
>>> +
>>> +  clocks:
>>> +    maxItems: 3
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: vdec
>>> +      - const: clk_vdec_mux
>>> +      - const: clk_hevcf_mux
>>> +
>>> +  power-domains:
>>> +    maxItems: 2
>>> +
>>> +  power-domain-names:
>>> +    items:
>>> +      - const: pwrc-vdec
>> Drop pwrc
>>
>>> +      - const: pwrc-hevc
>> Drop pwrc
> Ok, I'll drop the two pwrc(s) above.
>>
>> Missing iommus. I really doubt hardware works without IOMMU.
> 
> IOMMU is not supported by Amlogic SOCs, the decoder hardware needs to 
> use contiguous memory.

I assume you speak about hardware, not drivers, so it is fine.

Best regards,
Krzysztof