linux-kernel - Re: [PATCH v5 1/2] regmap: add flat cache with sparse validity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86d8d275-2552-49f1-b6b1-3fdb543d70f3@sirena.org.uk>
Date: Tue, 28 Oct 2025 11:38:49 +0000
From: Mark Brown <broonie@...nel.org>
To: Sander Vanheule <sander@...nheule.net>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v5 1/2] regmap: add flat cache with sparse validity

On Thu, Oct 23, 2025 at 03:50:31PM +0200, Sander Vanheule wrote:

> -	map->cache = kcalloc(regcache_flat_get_index(map, map->max_register)
> -			     + 1, sizeof(unsigned int), map->alloc_flags);

> +	cache = kmalloc(cache_data_size, map->alloc_flags);

kcalloc() does a zero initialisation so should be replace by kzalloc()
rather than kmalloc(), otherwise we break existing users who rely on the
zero initialisation.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)