linux-kernel - Re: [PATCH] iommu/of: Fix device node reference leak in of_iommu_get_resv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ea5b423-365f-46fe-94f1-ee248ad6b307@web.de>
Date: Tue, 28 Oct 2025 14:05:14 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Miaoqian Lin <linmq006@...il.com>, iommu@...ts.linux.dev,
 Jörg Rödel <joro@...tes.org>, Rob Herring
 <robh@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Thierry Reding <treding@...dia.com>, Will Deacon <will@...nel.org>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu/of: Fix device node reference leak in
 of_iommu_get_resv_regions

…
> Add a call to of_node_put() to release the reference after the usage.
…

How do you think about to use the attribute “__free(device_node)”?
https://elixir.bootlin.com/linux/v6.18-rc3/source/include/linux/of.h#L138
https://elixir.bootlin.com/linux/v6.18-rc3/source/drivers/iommu/of_iommu.c#L196-L271

Regards,
Markus