linux-kernel - Re: [PATCH] net: i825xx: replace printk() with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fcb18197-af45-4f7d-a435-39796c51c1e7@lunn.ch>
Date: Tue, 28 Oct 2025 14:24:56 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Dharanitharan R <dharanitharan725@...il.com>
Cc: sammy@...my.net, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: i825xx: replace printk() with pr_*() macros for
 cleaner logging

On Tue, Oct 28, 2025 at 10:01:27AM +0000, Dharanitharan R wrote:
> This patch replaces printk() calls in sun3_82586.c with appropriate pr_*()
> macros (pr_err, pr_info, etc.) according to Linux kernel logging conventions.

You have a Sun3? I've not seen one in maybe 25 years.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

says:

1.6.6. Clean-up patches

Netdev discourages patches which perform simple clean-ups, which are
not in the context of other work. For example:

Addressing checkpatch.pl, and other trivial coding style warnings

Addressing Local variable ordering issues

Conversions to device-managed APIs (devm_ helpers)

This is because it is felt that the churn that such changes produce
comes at a greater cost than the value of such clean-ups.

Please state in the commit message if you have run these patches on
hardware, and plan to do other work on the Sun3 driver, new features
etc.

    Andrew

---
pw-bot: cr