linux-kernel - Re: [PATCH v3 03/10] software node: allow referencing firmware nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <072411812faa1a9744eda9628afc7c7677f485b6.camel@pengutronix.de>
Date: Wed, 29 Oct 2025 14:16:04 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>, Andy Shevchenko	
 <andriy.shevchenko@...ux.intel.com>, Daniel Scally <djrscally@...il.com>, 
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Sakari Ailus
 <sakari.ailus@...ux.intel.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Danilo Krummrich	 <dakr@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
 	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-acpi@...r.kernel.org, Bartosz Golaszewski
 <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v3 03/10] software node: allow referencing firmware nodes

On Mi, 2025-10-29 at 13:55 +0100, Bartosz Golaszewski wrote:
> On Wed, Oct 29, 2025 at 1:51 PM Philipp Zabel <p.zabel@...gutronix.de> wrote:
> > 
> > > @@ -535,7 +535,13 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
> > >       ref_array = prop->pointer;
> > >       ref = &ref_array[index];
> > > 
> > > -     refnode = software_node_fwnode(ref->node);
> > > +     if (ref->swnode)
> > > +             refnode = software_node_fwnode(ref->swnode);
> > 
> > software_node_fwnode(ref->swnode) never returns NULL if given a non-
> > NULL parameter.
> > 
> 
> That's not true, it *will* return NULL if the software node in
> question has not yet been registered with the fwnode framework.

I completely missed the list lookup in software_node_to_swnode().
Thank you for the quick correction and additional context.

regards
Philipp