linux-kernel - Re: [PATCH] staging: vchiq_arm: delete unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86db61cb04863e9799eb20962a47ecdc@igalia.com>
Date: Wed, 29 Oct 2025 13:18:57 +0000
From: uajain <uajain@...lia.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@...adcom.com>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Stefan Wahren
 <wahrenst@....net>, Thomas Weißschuh
 <thomas.weissschuh@...utronix.de>, Rohit Chavan <roheetchavan@...il.com>,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: vchiq_arm: delete unnecessary check

On 2025-10-29 13:13, Dan Carpenter wrote:
> Both sides of this if else statement print exactly the same thing.
> Delete the unnecessary if statement.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

LGTM,
Reviewed-by: Umang Jain <uajain@...lia.com>

> ---
>  .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c   | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index e2cac0898b8f..130be2f58342 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -4001,10 +4001,7 @@ void vchiq_log_dump_mem(struct device *dev, const char *label, u32 addr,
>  		}
>  		*s++ = '\0';
>  
> -		if (label && (*label != '\0'))
> -			dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
> -		else
> -			dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
> +		dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
>  
>  		addr += 16;
>  		mem += 16;