linux-kernel - Re: [PATCH] Revert "scripts/coccinelle: Find PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47ef2f61-85c1-92fa-12dc-e5918d90488@inria.fr>
Date: Wed, 29 Oct 2025 15:04:36 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Gal Pressman <gal@...dia.com>
cc: Johan Hovold <johan@...nel.org>, Nicolas Palix <nicolas.palix@...g.fr>, 
    Jakub Kicinski <kuba@...nel.org>, Alexei Lazar <alazar@...dia.com>, 
    Simon Horman <horms@...nel.org>, cocci@...ia.fr, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "scripts/coccinelle: Find PTR_ERR() to %pe
 candidates"



On Wed, 29 Oct 2025, Gal Pressman wrote:

> Hi Johan,
>
> On 29/10/2025 15:29, Johan Hovold wrote:
> > This reverts commit 57c49d2355729c12475554b4c51dbf830b02d08d.
> >
> > Using "%pe" to print errnos is in no way mandated and a driver authors
> > may chose not to use it, for example, for consistency reasons.
> >
> > Drop the recently added cocci script that has gotten the build bots to
> > send warning emails about perfectly valid code and which will likely
> > only result in churn and inconsistency.
> >
> > Link: https://lore.kernel.org/all/aQHi4nUfIlcN1ac6@hovoldconsulting.com/
> > Signed-off-by: Johan Hovold <johan@...nel.org>
>
> The test by no means mandates authors to use %pe, as the output says:
> WARNING: Consider using %pe to print PTR_ERR()
>
> "Consider" :).
>
> I would consider it best practice to use it, and a few drivers were
> converted thanks to this test.
>
> If the issue is with automatic build bots, then maybe this test should
> be excluded from them, rather than deleted?

This is easy to do.  Or I can discard them when they come to me for
approval.

julia