linux-kernel - Re: [PATCH] tracing: fprobe: use ftrace if CONFIG_DYNAMIC_FTRACE_WITH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251029102304.2db99b7d@gandalf.local.home>
Date: Wed, 29 Oct 2025 10:23:04 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: mhiramat@...nel.org, jolsa@...nel.org, mathieu.desnoyers@...icios.com,
 jiang.biao@...ux.dev, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: fprobe: use ftrace if
 CONFIG_DYNAMIC_FTRACE_WITH_ARGS

On Wed, 29 Oct 2025 22:09:40 +0800
Menglong Dong <menglong8.dong@...il.com> wrote:

> Hi, it won't fail here, as FTRACE_OPS_FL_SAVE_ARGS has
> following definition:
> 
> #ifndef CONFIG_DYNAMIC_FTRACE_WITH_ARGS
> #define FTRACE_OPS_FL_SAVE_ARGS                        FTRACE_OPS_FL_SAVE_REGS
> #else
> #define FTRACE_OPS_FL_SAVE_ARGS                        0
> #endif

Bah, I should have known that, as I think I requested it :-p

[ chalks this up for a senior moment! ]


> 
> Which means it will fallback to FTRACE_OPS_FL_SAVE_REGS if
> CONFIG_DYNAMIC_FTRACE_WITH_ARGS not defined.
> 
> I have commit a PR to the bpf CI, and all testings passed and no
> building error happens:
>   https://github.com/kernel-patches/bpf/pull/10110

OK, thanks,

-- Steve