linux-kernel - Re: [PATCH v3 06/13] vfs: make vfs_create break delegations on parent directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9238724edeb1510b48a7b75cdc46075a82799dd8.camel@kernel.org>
Date: Wed, 29 Oct 2025 09:38:23 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Christian Brauner <brauner@...nel.org>
Cc: Miklos Szeredi <miklos@...redi.hu>, Alexander Viro
 <viro@...iv.linux.org.uk>,  Jan Kara <jack@...e.cz>, Chuck Lever
 <chuck.lever@...cle.com>, Alexander Aring <alex.aring@...il.com>,  Trond
 Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>, Steve
 French <sfrench@...ba.org>, Paulo Alcantara <pc@...guebit.org>, Ronnie
 Sahlberg <ronniesahlberg@...il.com>, Shyam Prasad N	
 <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>, Bharath SM	
 <bharathsm@...rosoft.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
  "Rafael J. Wysocki"	 <rafael@...nel.org>, Danilo Krummrich
 <dakr@...nel.org>, David Howells	 <dhowells@...hat.com>, Tyler Hicks
 <code@...icks.com>, NeilBrown <neil@...wn.name>,  Olga Kornievskaia
 <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Amir Goldstein
 <amir73il@...il.com>, Namjae Jeon	 <linkinjeon@...nel.org>, Steve French
 <smfrench@...il.com>, Sergey Senozhatsky	 <senozhatsky@...omium.org>,
 Carlos Maiolino <cem@...nel.org>, Kuniyuki Iwashima	 <kuniyu@...gle.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet	
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni	
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-nfs@...r.kernel.org, linux-cifs@...r.kernel.org, 
	samba-technical@...ts.samba.org, netfs@...ts.linux.dev,
 ecryptfs@...r.kernel.org, 	linux-unionfs@...r.kernel.org,
 linux-xfs@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 06/13] vfs: make vfs_create break delegations on
 parent directory

On Wed, 2025-10-29 at 14:23 +0100, Christian Brauner wrote:
> On Tue, Oct 21, 2025 at 11:25:41AM -0400, Jeff Layton wrote:
> > In order to add directory delegation support, we need to break
> > delegations on the parent whenever there is going to be a change in the
> > directory.
> > 
> > Add a delegated_inode parameter to vfs_create. Most callers are
> > converted to pass in NULL, but do_mknodat() is changed to wait for a
> > delegation break if there is one.
> > 
> > Reviewed-by: Jan Kara <jack@...e.cz>
> > Reviewed-by: NeilBrown <neil@...wn.name>
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > ---
> >  fs/ecryptfs/inode.c      |  2 +-
> >  fs/namei.c               | 26 +++++++++++++++++++-------
> >  fs/nfsd/nfs3proc.c       |  2 +-
> >  fs/nfsd/vfs.c            |  3 +--
> >  fs/open.c                |  2 +-
> >  fs/overlayfs/overlayfs.h |  2 +-
> >  fs/smb/server/vfs.c      |  2 +-
> >  include/linux/fs.h       |  2 +-
> >  8 files changed, 26 insertions(+), 15 deletions(-)
> > 
> > diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> > index 88631291b32535f623a3fbe4ea9b6ed48a306ca0..661709b157ce854c3bfdfdb13f7c10435fad9756 100644
> > --- a/fs/ecryptfs/inode.c
> > +++ b/fs/ecryptfs/inode.c
> > @@ -189,7 +189,7 @@ ecryptfs_do_create(struct inode *directory_inode,
> >  	rc = lock_parent(ecryptfs_dentry, &lower_dentry, &lower_dir);
> >  	if (!rc)
> >  		rc = vfs_create(&nop_mnt_idmap, lower_dir,
> > -				lower_dentry, mode, true);
> > +				lower_dentry, mode, true, NULL);
> 
> Starts to look like we should epxlore whether a struct create_args (or
> some other name) similar to struct renamedata I did some years ago would
> help make the code a bit more legible in the future.

I like that idea. Let me see if I can rework this patch along those
lines. I'll plan to send an updated set.

Thanks,
-- 
Jeff Layton <jlayton@...nel.org>