linux-kernel - Re: [PATCH 1/6] dt: bindings: net: add bindings for QCN6122

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52a0d7f1-e342-46a6-86e7-9852ac2f2eba@kernel.org>
Date: Wed, 29 Oct 2025 15:42:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: george.moussalem@...look.com, Johannes Berg <johannes@...solutions.net>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jeff Johnson <jjohnson@...nel.org>
Cc: linux-wireless@...r.kernel.org, devicetree@...r.kernel.org,
 ath11k@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] dt: bindings: net: add bindings for QCN6122

On 29/10/2025 15:32, Krzysztof Kozlowski wrote:
>>    interrupt-names:
>> @@ -87,6 +88,14 @@ properties:
>>      items:
>>        - const: wlan-smp2p-out
>>  
>> +  qcom,userpd:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [2, 3]
>> +    description: instance ID of user PD (protection domain) in multi-PD
>> +                 architectures to distinguish between multiple instances
>> +                 of the same wifi chip used by QMI in its interface with
>> +                 the firmware running on Q6.
> 
> Broken indentation. It is supposed to be two spaces. Look at this file -
> why are you doing this completely different?
> 
> Anyway, please do not come with 2nd or 3rd property for this. We already
> have such somewhere.

And reading the driver code, this is instance ID, so not really suitable
here. Sorry, such are not allowed. See writing bindings or my last OSSE
slides.

Best regards,
Krzysztof