linux-kernel - Re: [PATCH] fs/proc: fix uaf in proc_readdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251029-klammheimlich-gemein-801074b07089@brauner>
Date: Wed, 29 Oct 2025 16:37:07 +0100
From: Christian Brauner <brauner@...nel.org>
To: akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk,
	wangzijie1@...or.com,
	linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	albin_yang@....com
Cc: Christian Brauner <brauner@...nel.org>,
	albinwyang@...cent.com
Subject: Re: [PATCH] fs/proc: fix uaf in proc_readdir_de()

On Sat, 25 Oct 2025 10:42:33 +0800, albin_yang@....com wrote:
> Pde is erased from subdir rbtree through rb_erase(), but not set the node to EMPTY,
> which may result in uaf access. We should use RB_CLEAR_NODE() set the erased node
> to EMPTY, then pde_subdir_next() will return NULL to avoid uaf access.
> 
> We found an uaf issue while using stree-ng testing, need to run testcase getdent and
> tun in the same time. The steps of the issue is as follows:
> 1) use getdent to traverse dir /proc/pid/net/dev_snmp6/, and current pde is tun3;
> 2) in the [time windows] unregister netdevice tun3 and tun2, and erase them from
>    rbtree. erase tun3 first, and then erase tun2. the pde(tun2) will be released
>    to slab;
> 3) continue to getdent process, then pde_subdir_next() will return pde(tun2) which
>    is released, it will case uaf access.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] fs/proc: fix uaf in proc_readdir_de()
      https://git.kernel.org/vfs/vfs/c/60a7b9983b80