linux-kernel - Re: [PATCH v3] dt_bindings: sound: ti,pcm186x: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251029-figure-greeting-d2cd3b0106e1@spud>
Date: Wed, 29 Oct 2025 17:46:26 +0000
From: Conor Dooley <conor@...nel.org>
To: Ranganath V N <vnranganath.20@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org, david.hunter.linux@...il.com,
	khalid@...nel.org, linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v3] dt_bindings: sound: ti,pcm186x: convert to dtschema

On Wed, Oct 29, 2025 at 10:53:04AM +0530, Ranganath V N wrote:
> convert the Texas Instruments PCM186x Universal audio ADC bindings
> to DT schema.
> 
> Signed-off-by: Ranganath V N <vnranganath.20@...il.com>
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm186x.yaml b/Documentation/devicetree/bindings/sound/ti,pcm186x.yaml

> +properties:
> +  compatible:
> +    enum:
> +      - ti,pcm1862
> +      - ti,pcm1863
> +      - ti,pcm1864
> +      - ti,pcm1865

Usually we want the filename to match one of compatibles in the file,
rather than have wildcards.

Secondly, the subject is not really as expected for a binding, let alone
one in sound. It should be "ASoC: dt-bindings: ".

With those,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
pw-bot: changes-requested

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)