[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <wgxgjhzbkkzbjz64bshooo7mstnpm7ames66e4ctjwjyx3p52i@j6db4r2x64nm>
Date: Wed, 29 Oct 2025 19:03:35 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Luca Weiss <luca@...aweiss.eu>, ~postmarketos/upstreaming@...ts.sr.ht,
phone-devel@...r.kernel.org, Loic Poulain <loic.poulain@....qualcomm.com>,
Robert Foss <rfoss@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Bartosz Golaszewski <brgl@...ev.pl>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953
compatible
Hi,
On Wed, Oct 29, 2025 at 10:36:16AM +0100, Konrad Dybcio wrote:
> On 10/28/25 5:40 PM, Luca Weiss wrote:
> > Add the msm8953 CCI device string compatible.
> >
> > Signed-off-by: Luca Weiss <luca@...aweiss.eu>
> > ---
> > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> > index 9bc99d736343..ef8f5fe3a8e1 100644
> > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> > @@ -15,6 +15,7 @@ properties:
> > oneOf:
> > - enum:
> > - qcom,msm8226-cci
> > + - qcom,msm8953-cci
> > - qcom,msm8974-cci
> > - qcom,msm8996-cci
> >
> > @@ -146,6 +147,7 @@ allOf:
> > - contains:
> > enum:
> > - qcom,msm8916-cci
> > + - qcom,msm8953-cci
> >
> > - const: qcom,msm8996-cci
>
> Sorry for only bringing it up now - could you check whether
> all the clocks that you defined are actually necessary?
>
> It may be that you can do without CAMSS_AHB_CLK and/or
> TOP_AHB_CLK
I was about to merge this. I'll wait for Luca's confirmation.
Andi
Powered by blists - more mailing lists