linux-kernel - Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251028170842.3fdaea7e@kernel.org>
Date: Tue, 28 Oct 2025 17:08:42 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: Wang Liang <wangliang74@...wei.com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 shuah@...nel.org, acardace@...hat.com, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 yuehaibing@...wei.com, zhangchangzhong@...wei.com
Subject: Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail
 by installing ethtool-common.sh

On Tue, 28 Oct 2025 17:14:03 +0000 Simon Horman wrote:
> > +TEST_FILES := ethtool-common.sh
> > +
> >  include ../../../lib.mk  
> 
> Hi Wang Liang,
> 
> As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
> I think the desired format is as follows (completely untested!):
> 
> TEST_FILES := \
> 	ethtool-common.sh \
> # end of TEST_PROGS

I believe we (intentionally) allow simple single entry assignment like
in this patch. But there have been bugs in this check which I only fixed
last weekend so please LMK if I'm missing something..