linux-kernel - Re: accel/amdxdna: Fix incorrect command state for timed out job

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4c8b7be-588d-b0b7-00ca-e60cbde034a6@amd.com>
Date: Wed, 29 Oct 2025 11:38:51 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Markus Elfring <Markus.Elfring@....de>, <dri-devel@...ts.freedesktop.org>,
	Jeffrey Hugo <quic_jhugo@...cinc.com>, Maciej Falkowski
	<maciej.falkowski@...ux.intel.com>, Oded Gabbay <ogabbay@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, Mario Limonciello
	<mario.limonciello@....com>, Max Zhen <max.zhen@....com>, Sonal Santan
	<sonal.santan@....com>
Subject: Re: accel/amdxdna: Fix incorrect command state for timed out job


On 10/29/25 00:53, Markus Elfring wrote:
>> What are the duplicate statements?
>>
>> Sorry that I am still a little confused.
>>
>>
>> The code change is to distinguish between the job which is  timed out and the job is aborted.
> Would you like to clarify the usage incidence for amdxdna_cmd_set_state() calls
> in combination with assignments to the variable “ret” (according to the implementation
> of the affected function “aie2_sched_resp_handler”)?
> https://elixir.bootlin.com/linux/v6.18-rc3/C/ident/amdxdna_cmd_set_state

Sure. amdxdna_cmd_set_state() updates the return code to command buffer. 
So application which issues the command will be able to get the return code.

The function return value "ret" is used by mailbox receiving kernel 
thread to deal with the error.


Thanks,

Lizhi

>
> Regards,
> Markus