linux-kernel - Re: [PATCH 0/2] x86/virt/tdx: Minor sparse fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22422512e68eb6a62b137379ff3f25436d75af56.camel@intel.com>
Date: Wed, 29 Oct 2025 20:53:52 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "seanjc@...gle.com" <seanjc@...gle.com>, "bp@...en8.de" <bp@...en8.de>,
	"kas@...nel.org" <kas@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
	"mingo@...hat.com" <mingo@...hat.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "x86@...nel.org" <x86@...nel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "Li, Xiaoyao" <xiaoyao.li@...el.com>
Subject: Re: [PATCH 0/2] x86/virt/tdx: Minor sparse fixups

On Wed, 2025-10-29 at 12:48 -0700, Dave Hansen wrote:
> Sean recently suggested relying on sparse to add type safety in TDX code,
> hoping that the robots would notice and complain. Well, that plan is not
> working out so great. TDX is not even sparse clean today and nobody seems
> to have noticed or cared.
> 
> I can see how folks might ignore the 0 vs. NULL complaints. But the
> misplaced __user is actually bad enough it should be fixed no matter
> what.
> 
> Might as well fix it all up.

Oof. But my local distro version of sparse spit out a bunch of noise related to
"warning: unreplaced symbol" in "include/asm-generic/bitops/generic-non-
atomic.h". It also did not find these. But checking with the latest sparse build
from source did, and this fixes them.