linux-kernel - Re: [PATCH v2] staging: sm750fb: style fixes: align call and split chained assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQGmSIinidUQnHT4@stanley.mountain>
Date: Wed, 29 Oct 2025 08:29:44 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Cristian Del Gobbo <cristiandelgobbo87@...il.com>
Cc: sudip.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	gregkh@...uxfoundation.org, linux-fbdev@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: style fixes: align call and split
 chained assignment

This patch was really confusing because I had no idea what I reported.
Just remove my reported by tag...

This is not a v2 patch, it's a whole new patch.  Don't call it a v2.

On Wed, Oct 29, 2025 at 03:21:23AM +0100, Cristian Del Gobbo wrote:
> - Drop previous change that made g_fbmode[] elements const (broke build).

But if it were a v2, this isn't the right way to send a v2.  In a v2 this
would go under the --- cut off line.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

> - Align the continued arguments of sm750_hw_cursor_set_size() with the
>   opening parenthesis.
> - Replace a chained assignment of red/green/blue with a temporary
>   variable to satisfy checkpatch and improve readability.

These are unrelated changes.  Do them as separate patches.

> 
> No functional change intended.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> Signed-off-by: Cristian Del Gobbo <cristiandelgobbo87@...il.com>

Also run your patch through checkpatch.pl.

> ---
>  drivers/staging/sm750fb/sm750.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 3659af7e519d..94a99af4320e 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -121,8 +121,8 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)
>  	sm750_hw_cursor_disable(cursor);
>  	if (fbcursor->set & FB_CUR_SETSIZE)
>  		sm750_hw_cursor_set_size(cursor,
> -					fbcursor->image.width,
> -					fbcursor->image.height);
> +					 fbcursor->image.width,
> +					 fbcursor->image.height);
>  
>  	if (fbcursor->set & FB_CUR_SETPOS)
>  		sm750_hw_cursor_set_pos(cursor,
> @@ -538,7 +538,11 @@ static int lynxfb_ops_setcolreg(unsigned int regno,
>  	}
>  
>  	if (info->var.grayscale)
> -		red = green = blue = (red * 77 + green * 151 + blue * 28) >> 8;
> +		int y = (red * 77 + green * 151 + blue * 28) >> 8;

y is a strange variable name.  It has nothing to do with the y axis.

regards,
dan carpenter